Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] : fix #14521 #14816

Merged
merged 5 commits into from Mar 7, 2024
Merged

Conversation

jensenojs
Copy link
Contributor

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue #14521

What this PR does / why we need it:

The previous code didn't take into account the out-of-order case such as

create table t(a int, b varchar, c varchar, primary key(c, a));
explain insert into t (b, c, a) values("b", "c", 1);

now fix it

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Mar 6, 2024
@mergify mergify bot requested a review from sukki37 March 6, 2024 10:11
@mergify mergify bot added the kind/bug Something isn't working label Mar 6, 2024
@jensenojs
Copy link
Contributor Author

create table t(a int, b varchar, c varchar, primary key(c, a));
explain insert into t (b, c, a) values("b", "c", 1);

previous

image

now

image

@jensenojs
Copy link
Contributor Author

相关的cases已经在main上固定在bvt中

@mergify mergify bot merged commit 5d4ff58 into matrixorigin:1.1-dev Mar 7, 2024
17 of 18 checks passed
@jensenojs jensenojs deleted the fix_14521_for_1.1 branch March 7, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants