Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync to 1.1: adjust the db, table visibility in show accounts #14924

Merged
merged 4 commits into from Mar 13, 2024

Conversation

gouhongshen
Copy link
Contributor

@gouhongshen gouhongshen commented Mar 12, 2024

What type of PR is this?

  • API-change
  • BUG
  • Improvement
  • Documentation
  • Feature
  • Test and CI
  • Code Refactoring

Which issue(s) this PR fixes:

issue ##13376

What this PR does / why we need it:

  1. index table(__index_xxx): do not counting it into the table_count, but need its size.
  2. mo_increment_columns: do not counting it into the table_count, but need its size.
  3. subscription db: do not count it into the db_count, and its size
  4. sys table(mo_database, mo_tables, mo_column): count them into the table_count, and need their sizes

@matrix-meow matrix-meow added the size/S Denotes a PR that changes [10,99] lines label Mar 12, 2024
@mergify mergify bot requested a review from sukki37 March 12, 2024 10:35
@mergify mergify bot added the kind/bug Something isn't working label Mar 12, 2024
mergify bot pushed a commit that referenced this pull request Mar 13, 2024
1. index table(__index_xxx): do not counting it into the `table_count`, but need its size.
2. mo_increment_columns: do not counting it into the `table_count`, but need its size.
3. subscription db: do not count it into the `db_count`, and its size
4. sys table(mo_database, mo_tables, mo_column): count them into the `table_count`, and need their sizes

cherry-pick to 1.1: #14924

Approved by: @qingxinhome
@mergify mergify bot merged commit cfdc043 into matrixorigin:1.1-dev Mar 13, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working size/S Denotes a PR that changes [10,99] lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants