modify defaultMaxLockRowCount to reduce deadlocks

[iamlinjunhong]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #https://github.com/matrixorigin/MO-Cloud/issues/2984?from_wecom=1

What this PR does / why we need it:

modify defaultMaxLockRowCount to reduce deadlocks

[matrix-meow]

@iamlinjunhong Thanks for your contributions!

Pull Request Review:

Problem:

1. Security Concern:
   • Changing defaultMaxLockRowCount from 1024 to 1000000 can potentially lead to performance issues and resource exhaustion. Allowing a significantly higher number of lock rows could increase the risk of denial-of-service attacks or resource contention.

Suggestions to Address:

1. Security Mitigation:
   • It is crucial to carefully evaluate the impact of increasing defaultMaxLockRowCount to such a high value. Consider conducting performance testing to ensure that the system can handle the increased load without adverse effects.
   • Implement rate limiting or other mechanisms to prevent abuse or excessive resource consumption when dealing with a large number of lock rows.
   • Consider setting a more reasonable upper limit for defaultMaxLockRowCount that balances performance and security concerns.

Optimization:

1. Code Clarity:
   • It would be beneficial to provide a brief explanation in the pull request body regarding the rationale behind the significant increase in defaultMaxLockRowCount. This can help other developers understand the purpose and implications of the change more easily.
   • Ensure that the comments in the code are updated to reflect the new value of defaultMaxLockRowCount for better code documentation.

Overall:

• While the intention to reduce deadlocks is valid, it is essential to consider the security implications and potential performance impact of such a change. Conduct thorough testing and consider implementing safeguards to prevent abuse or resource exhaustion. Additionally, providing clear explanations in the pull request body and updating code comments can enhance code readability and maintainability.

By addressing the security concern and optimizing the code clarity, the pull request can be improved to ensure a balance between performance, security, and maintainability.