-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the estimation of tcp packet num send back to client #16364
Conversation
1. base part: flush op cnt 2. upload part: calculation = payload / 16KiB 3. response part: calculation = sendByte / 4KiB
@xzxiong Thanks for your contributions! Here are review comments for file pkg/frontend/mysql_protocol.go: Pull Request Review:Title:The title of the pull request is clear and concise, indicating that the purpose of the changes is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request provides information about the type of PR (Improvement), the specific issue it fixes (#2774), and a brief description of the changes made. Changes:
Suggestions for Improvement:
By addressing these suggestions, the codebase can be improved in terms of readability, maintainability, and security. Here are review comments for file pkg/frontend/session.go: Pull Request Review:Title:The title of the pull request is clear and indicates that the goal is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request provides relevant information about the type of PR (Improvement), the specific issue it addresses (#2774), and a brief summary of the changes made. Changes:
Feedback and Suggestions for Improvement:
By addressing the suggestions mentioned above, the codebase can be improved in terms of clarity, consistency, security, and potentially performance. Here are review comments for file test/distributed/cases/log/query_tcp.result: Pull Request Review:Title:The title of the pull request is clear and concise, indicating that the goal is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request is brief and lacks detailed information. It mentions that the PR is an improvement and is related to fixing issue #2774. However, there is no explanation of the specific changes made or the rationale behind them. Changes:The changes made in the pull request are not provided in the diff section, which makes it difficult to review the actual code modifications. Without the changes displayed, it is challenging to assess the impact of the optimization on the codebase. Feedback and Suggestions:
Overall, to improve the quality of the pull request:
By addressing these points, the pull request can be enhanced to effectively optimize the estimation of TCP packet numbers while maintaining code quality and security. Here are review comments for file test/distributed/cases/log/query_tcp.sql: Pull Request Review:Title:The title of the pull request is clear and indicates that the goal is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request provides information about the type of PR (BUG, Improvement), the specific issue it fixes, and the changes made in the code related to the issue. It references issue #2774 on GitHub, which is helpful for tracking the context of the changes. Changes:The changes in the pull request are related to a SQL file Feedback and Suggestions for Improvement:
In conclusion, addressing the security concerns, optimizing the test data setup, improving code readability, enhancing testing coverage, documenting the changes effectively, and following version control best practices will contribute to the overall quality and maintainability of the codebase. Here are review comments for file test/distributed/cases/zz_statement_query_type/query_tcp.result: Pull Request Review:Title:The title of the pull request is clear and indicates that the aim is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request provides information about the type of PR, the specific issue it fixes, and the changes made in the code related to the issue. It references the issue #2774 on GitHub for context. Changes:
Feedback and Suggestions for Improvement:
By addressing the above points, the pull request can not only optimize the estimation of TCP packet numbers but also enhance the overall quality and security of the codebase. Here are review comments for file test/distributed/cases/zz_statement_query_type/query_tcp.sql: Pull Request Review:Title:The title of the pull request is clear and indicates that the goal is to optimize the estimation of TCP packet numbers sent back to the client. Body:The body of the pull request provides information about the type of PR (Improvement), the issue it fixes, and the changes made in the code related to the optimization of TCP packet estimation. Changes:
Feedback and Suggestions for Improvement:
In conclusion, while the optimization of TCP packet estimation is a valuable improvement, addressing code clarity, security concerns, optimization, testing, and documentation will enhance the quality and maintainability of the codebase. |
#16412) ref: #16364 changes: 1. count mo do logic Flush op, see CountPacket() 2. calculate basic number of tcp packets written to client, base on the write buffer size 4096 byte. 3. add bvt case, verify the basic result. 4. change config observability::tcpPacket default = true Approved by: @qingxinhome, @heni02, @daviszhen, @sukki37
What type of PR is this?
Which issue(s) this PR fixes:
issue # https://github.com/matrixorigin/MO-Cloud/issues/2774#issuecomment-2128654059
What this PR does / why we need it:
changes: