fix a bug that cause tpch performance regression #17310
Merged
+57
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…join (matrixorigin#17265)" This reverts commit cb3bf73. Conflicts: pkg/sql/compile/compile.go
ouyuanning
approved these changes
Jul 3, 2024
badboynt1
added a commit
to badboynt1/matrixone
that referenced
this pull request
Jul 4, 2024
为了修复bug，在matrixorigin#17265 这个pr中引入了一个导致tpch性能下降的bug。 现在需要修复bug，并且保证所有query的性能都不会下降 Approved by: @ouyuanning Conflicts: pkg/sql/compile/compile.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #https://github.com/matrixorigin/MO-Cloud/issues/3194
What this PR does / why we need it:
为了修复bug，在#17265 这个pr中引入了一个导致tpch性能下降的bug。
现在需要修复bug，并且保证所有query的性能都不会下降