New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #8599: move task schedule to a separate goroutine #9775
Conversation
@gouhongshen Thanks for your contributions! The pull request aims to fix issue #8599 by moving the task schedule from the ticker normal routine to a separate goroutine. The changes include adding a new function There are no major issues with the changes made in the pull request. However, there are a few minor issues that need to be addressed:
To address these issues, the pull request title and body should be updated to provide more detail about the changes made and their benefits. The |
What type of PR is this?
Which issue(s) this PR fixes:
issue #8599
What this PR does / why we need it:
moving the task schedule from the ticker normal routine to a separate goroutine can avoid the hakeeper's health check and tick update operations being blocked by the task schedule, or the tick will be skipped and can not correctly estimate the time passing.
and I have already added some unit tests.