Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface start screen not available from non-MATRX hosting website #175

Closed
thaije opened this issue Jun 5, 2020 · 2 comments
Closed

Interface start screen not available from non-MATRX hosting website #175

thaije opened this issue Jun 5, 2020 · 2 comments
Assignees
Labels
bug Something isn't working front-end Work related to the front end

Comments

@thaije
Copy link
Collaborator

thaije commented Jun 5, 2020

Describe the bug
If you host MATRX on a laptop with a local network, only the hosting laptop can access the agent overview page (localhost:3000). Connecting with another laptop to that network and trying to access that page throws an error in the console.

To Reproduce
Do the steps above.

Expected behavior
God agent is also available from other non-MATRX hosting laptops.

Additional context
Other agents are accessible, only the localhost:3000 page is not available. Most likely the cause is in the dashboard.js file where the url is hardcoded to localhost.

@thaije thaije added bug Something isn't working front-end Work related to the front end labels Jun 5, 2020
@thaije thaije self-assigned this Jun 5, 2020
@jwaa
Copy link
Member

jwaa commented Jul 7, 2020

@thaije Now more and more projects will be doing experiments with MATRX, including a "Wizard" who needs to start/pause/stop the task, would it make sense to fix this bug in the next milestone (or even in an upcoming hotfix)? I have no idea how much effort this would be. Perhaps the option of providing an IP adress to the default visualization through the world builder (that defaults to "localhost")? No idea how we get that in the dashboard.js though.

@thaije thaije added this to the Release v1.2.0 milestone Jul 8, 2020
@thaije
Copy link
Collaborator Author

thaije commented Jul 8, 2020

@jwaa The fix itself is trivial. I added it to the next release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front-end Work related to the front end
Projects
None yet
Development

No branches or pull requests

2 participants