Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Door object has hardcoded customizable properties #318

Closed
thaije opened this issue Jan 5, 2022 · 1 comment
Closed

Door object has hardcoded customizable properties #318

thaije opened this issue Jan 5, 2022 · 1 comment
Assignees
Labels
bug Something isn't working core Work related to the core functionality

Comments

@thaije
Copy link
Collaborator

thaije commented Jan 5, 2022

Describe the bug
The Door object has its customizable properties hardcoded: https://github.com/matrx-software/matrx/blob/master/matrx/objects/standard_objects.py#L71

This should be changed such that it can be set by the user as well. It is primarily a problem as the WorldBuilder.add_room allows passing the door_customizable_properties, which are then thus ignored.

To Reproduce
Create a door with a property such as img_name, pass img_name as well in the customizable_properties, and try the img_name in an action with door.change_property("img_name", "new_img_name.png". This change is ignored.

Expected behavior
Door object can be passed a customizable_properties list that it listens to.

@thaije thaije added bug Something isn't working core Work related to the core functionality labels Jan 5, 2022
@thaije
Copy link
Collaborator Author

thaije commented Jan 5, 2022

@BirgitvdS this is your issue

@thaije thaije self-assigned this Feb 7, 2022
@thaije thaije closed this as completed Feb 7, 2022
@thaije thaije mentioned this issue Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Work related to the core functionality
Projects
None yet
Development

No branches or pull requests

1 participant