Add Pomodoro timer

[koozz]

A minimalistic Pomodoro timer.

[keithamus]

The $0 needs to be quoted otherwise if the path contains spaces then things could go wrong.

[keithamus]

Hey @koozz awesome plugin! I've made some notes about small changes - mostly syntactical, by using shellcheck to lint the file. If you could please correct these then I'll happily merge 😄

[koozz]

There are 3 messages from shellcheck that I cannot seem to fix.

In pomodoro.1s.sh line 20:
source "$POMODORO_DATA"
^-- SC1090: Can't follow non-constant source. Use a directive to specify location.


In pomodoro.1s.sh line 29:
    local now=$(date +"%s")
          ^-- SC2155: Declare and assign separately to avoid masking return values.


In pomodoro.1s.sh line 45:
  local now=$(date +"%s")
        ^-- SC2155: Declare and assign separately to avoid masking return values.

Is that urgent enough to fix?

[keithamus]

SC2155 just means you should declare first, then assign after. For example:

local now;
now=$(date +"%s")

As for SC1090, you just need to comment the line above; so:

# shellcheck source=~/.bitbar/plugins/pomodoro.data
source "$POMODORO_DATA"

Or alternatively you can disable the check:

# shellcheck disable=SC1090
source "$POMODORO_DATA"

[matryer]

see #180

[keithamus]

Hey @koozz, thanks very much for working on this - and thanks also for being responsive to my comments and making the right fixes.

Another user (@gorangajic) has also made a Pomodoro plugin - around the same time as yours. We've gone with theirs, and so I'm going to close this one. Please don't take this as a sign that we don't value your work - we really do! Please don't let this put you off from making PRs in the future! We'd love to see some more great code from you 😄.

[matryer]

Here, here.

[koozz]

Sorry, I didn't know about the other work in progress.
Just fiddled around and made this one. It's pretty minimalistic, but I'll keep it around for my own use :)