Skip to content
This repository has been archived by the owner on Mar 19, 2022. It is now read-only.

Add proxy settings to solo.rb.erb #254

Closed
wants to merge 1 commit into from

Conversation

tocky
Copy link
Contributor

@tocky tocky commented Jun 10, 2013

solo.rb which is generated automatically does not include proxy settings.

solo.rb which is generated automatically does not include proxy settings.
@tmatilai
Copy link
Collaborator

@tocky, thanks for the PR. At some point I thought about this but forgot to file an issue.

You should install also the chef-solo-search submodule: git submodule update --init. Now there is an erroneous Manifest change included. But I can also fix it myself when merging later after a bit of testing.

@tocky
Copy link
Contributor Author

tocky commented Jun 10, 2013

@tmatilai, I apologize for the mistake. Then I'll attempt to add the submodule, and send you a pull-request again.

@tmatilai
Copy link
Collaborator

@tocky oh, not a problem. git submodules are tricky and we might get rid of that on some point. Don't spend too much time on that, I can skip that part of the commit.

@tocky
Copy link
Contributor Author

tocky commented Jun 10, 2013

Yeah, thank you @tmatilai

@matschaffer
Copy link
Owner

Agreed. I often wish git would at least ask you if you want to also clone
the submodules. I see this sort of problem far too often.

Thanks for the patch, @tocky!

-Mat

about.me/matschaffer

On Mon, Jun 10, 2013 at 8:52 AM, Shin Tokiwa notifications@github.comwrote:

Yeah, thank you @tmatilai https://github.com/tmatilai


Reply to this email directly or view it on GitHubhttps://github.com//pull/254#issuecomment-19207837
.

@tmatilai tmatilai closed this in 58a68f6 Jun 14, 2013
@tmatilai
Copy link
Collaborator

Merged to master. Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants