explicitly execute bash script in bash

[robacarp]

Fix for Issue #350

I put the if/else block on one line to give the best possibility of whatever random shell on the client passing the whole command string on to bash. In my testing, csh seems to have the most trouble with multiline strings. I'm not familiar enough with it to know if there is a cleaner way to send the command string through to bash.

I hardcoded /bin/sh as the shell because the opscode install.sh script already depends on /bin/sh.

[tmatilai]

Thanks!

Could you test just adding the semicolons after the curl and wget lines? Or if the newline character really is the issue, we can eat it with a backslash at the end of lines. I think that one-liner is not very readable.

[robacarp]

It is amazing what a few hours of sleep will do...I had previously tried the backslashes and found an incompatibility with fishshell. However, adding semicolons after curl/wget and backslashes for the newlines passes through every shell I could find. Good suggestion.

I tested both execution paths (curl and wget) by duplicating the if block and forcing fail on the second one, and running knife solo prepare somebox while manually iterating through csh, sh, dash, bash, and fish. csh and fish being the keys as they're not necessarily bash compatible.