This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
implement a experimental ssh-keepalive feature #222 #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,8 +288,21 @@ def run_command(command, options = {}) | |||
| result.exit_code = data.read_long | |||
| end | |||
|
|
|||
| if keepalive_interval | |||
| jitter_seconds = 3 # TODO: Fix this magic number | |||
There was a problem hiding this comment.
So.... why the magic number? ;)
There was a problem hiding this comment.
I think that the '3' is looks like suddenly appeared in the source code. And I think it should be a constant with a comment. But it maybe a matter of preference.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wrote a experimental implementation of the ssh keepalive using only the current net-ssh functionalities.
The point is:
ssh.loopmethod. (It will be used as the IO.select 's fourth argument)So, when the '--ssh-keepalive' option is specified, knife-solo will send a SSH_MSG_IGNORE packet at regular intervals. But when the '--ssh-keepalive' option is not specified, knife-solo's behavior is not changed.
This code would be avoid a knife-solo hang up issue like #222.
But I think that this is not a very good idea...