Update for compatibility with JOSM API >= 12881 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded equivalents This time for unit tests.
See https://josm.openstreetmap.de/ticket/15310. This commit only makes the bare minimum of changes to comply with the new API (e.g. deprecated parts of the API are still used).
I used either `Config.getPref()` (especially for preferences without default value) or subclasses of `AbstractToStringProperty` (like `BooleanProperty`). While doing this, I tried to minimize the number of times a property is instantiated, in order to avoid duplication of e.g. default values. See https://josm.openstreetmap.de/ticket/15229#comment:102 for the reasoning behind this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces calls to deprecated API methods or methods that have already been removed from the API.
All of these changes are also included in #64, so if you apply that PR, you don't need this one.
You'll need to adjust the unit tests, because the version of the JOSM testutils that you use is out of date. Otherwise this pull request fixes most of #65.
In PR #64 I fixed the problem with the outdated JOSM testutils, by using the automatically updated
josm-unittest.jarartifact.