Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Switch to alpha ordered imports #13

Merged
merged 4 commits into from
Sep 27, 2019

Conversation

lhsazevedo
Copy link
Contributor

Laravel is now using alphabetically ordered imports.

@HDVinnie
Copy link

Not a fan. 100% preffered length ordering!

@lhsazevedo
Copy link
Contributor Author

lhsazevedo commented Sep 17, 2019

It's not that pretty but I find it way more readable.

You can override the rule easily.

@lhsazevedo
Copy link
Contributor Author

lhsazevedo commented Sep 18, 2019

For some reason, 7.2 Travis build with COMPOSER_FLAGS="--prefer-stable --prefer-lowest" var is failing.

@matt-allan
Copy link
Owner

I think the laravel/framework dependency probably needs to be locked to 1bbe5528568555d597582fdbec73e31f8a818dbc as the minimum revision constraint. Otherwise the tests will install a version that uses alpha ordered imports and fail. For example, "dev-master#1bbe552" should work.

@lhsazevedo
Copy link
Contributor Author

lhsazevedo commented Sep 20, 2019

Can we constrain to ^6.0.3? This release merges the new ordering.

@matt-allan
Copy link
Owner

@lhsazevedo yeah, if there is a stable release that would be better.

@lhsazevedo
Copy link
Contributor Author

🚀

@matt-allan
Copy link
Owner

Thanks!

@matt-allan matt-allan merged commit addc0fe into matt-allan:master Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants