Skip to content

Commit

Permalink
facebook#22990 add RCTDatePickerNativeComponent types (facebook#23013)
Browse files Browse the repository at this point in the history
Summary:
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change:

Changelog:
----------

[iOS] [Changed] - As mentioned in facebook#22990, I have moved native components required by DatePickerIOS.ios.js into separate files and added Flow Typing.
Pull Request resolved: facebook#23013

Differential Revision: D13697591

Pulled By: TheSavior

fbshipit-source-id: 5aec5a2270cbfc708f3e3a67662abd8071f1333f
  • Loading branch information
ni3t authored and facebook-github-bot committed Jan 16, 2019
1 parent cd7b0ec commit ea9e0d4
Show file tree
Hide file tree
Showing 2 changed files with 44 additions and 4 deletions.
7 changes: 3 additions & 4 deletions Libraries/Components/DatePicker/DatePickerIOS.ios.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,11 @@ const StyleSheet = require('StyleSheet');
const View = require('View');

const invariant = require('invariant');
const requireNativeComponent = require('requireNativeComponent');

import type {ViewProps} from 'ViewPropTypes';
import type {SyntheticEvent} from 'CoreEventTypes';

const RCTDatePickerIOS = requireNativeComponent('RCTDatePicker');
const RCTDatePickerNativeComponent = require('RCTDatePickerNativeComponent');

type Event = SyntheticEvent<
$ReadOnly<{|
Expand Down Expand Up @@ -119,7 +118,7 @@ class DatePickerIOS extends React.Component<Props> {
};

// $FlowFixMe How to type a native component to be able to call setNativeProps
_picker: ?React.ElementRef<typeof RCTDatePickerIOS> = null;
_picker: ?React.ElementRef<typeof RCTDatePickerNativeComponent> = null;

componentDidUpdate() {
if (this.props.date) {
Expand Down Expand Up @@ -147,7 +146,7 @@ class DatePickerIOS extends React.Component<Props> {
);
return (
<View style={props.style}>
<RCTDatePickerIOS
<RCTDatePickerNativeComponent
testID={props.testID}
ref={picker => {
this._picker = picker;
Expand Down
41 changes: 41 additions & 0 deletions Libraries/Components/DatePicker/RCTDatePickerNativeComponent.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
* @flow
*/

'use strict';

const requireNativeComponent = require('requireNativeComponent');

import type {SyntheticEvent} from 'CoreEventTypes';
import type {ViewProps} from 'ViewPropTypes';
import type {NativeComponent} from 'ReactNative';

type Event = SyntheticEvent<
$ReadOnly<{|
timestamp: number,
|}>,
>;

type NativeProps = $ReadOnly<{|
...ViewProps,
date?: ?number,
initialDate?: ?Date,
locale?: ?string,
maximumDate?: ?number,
minimumDate?: ?number,
minuteInterval?: ?(1 | 2 | 3 | 4 | 5 | 6 | 10 | 12 | 15 | 20 | 30),
mode?: ?('date' | 'time' | 'datetime'),
onChange?: ?(event: Event) => void,
timeZoneOffsetInMinutes?: ?number,
|}>;
type RCTDatePickerNativeType = Class<NativeComponent<NativeProps>>;

module.exports = ((requireNativeComponent(
'RCTDatePicker',
): any): RCTDatePickerNativeType);

0 comments on commit ea9e0d4

Please sign in to comment.