Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READMEの修正 #124

Merged
merged 1 commit into from
Jan 31, 2018
Merged

READMEの修正 #124

merged 1 commit into from
Jan 31, 2018

Conversation

tenmihi
Copy link
Contributor

@tenmihi tenmihi commented Jan 31, 2018

理由

CountDispatcherでCount.ActionTypeを渡してDispatchしてますが,これだと実際Reducerに対応したAction
がないと判断されてしまう

修正ファイル

  • README.md

修正内容

CountDispatcherでCount.ActionTypeとしているところを,ActionCreatorを通してActionを作ってそれをDispatchしてあげるように変更

@tenmihi
Copy link
Contributor Author

tenmihi commented Jan 31, 2018

もともと丁寧なREADMEであると私は感じているので,軽微な修正点ですが直してあげたいです 🙇

@mattak
Copy link
Owner

mattak commented Jan 31, 2018

LGTM
@tenmihi SUPEEEEERRRRRRR AWESOME!!!!
Thanks for reporting! I merge it.

@mattak mattak merged commit 3797b99 into mattak:master Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants