Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error handling for bulk indexing to provide more information… #219

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Improved error handling for bulk indexing to provide more information… #219

wants to merge 6 commits into from

Conversation

gburgett
Copy link

@gburgett gburgett commented Aug 6, 2015

I've been trying to use the bulk indexer in an app we're writing, and we're finding that we need to be more intelligent about error handling. For instance, in our setup we point the app at a load balancer which redirects to our Elasticsearch nodes. If all nodes are down we get a 503 with some html, and the elastigo library returns this as a json parsing error.

I've put in some improvements for better error handling, and a unit test which more closely demonstrates our need.

@gburgett
Copy link
Author

gburgett commented Aug 6, 2015

Btw, this would fix #198

@weberr13
Copy link
Collaborator

do you mind rebasing @gburgett? I'm trying to get as many of these out of the way so we can focus on the breaking change PR's that are still pending.

@weberr13
Copy link
Collaborator

I merged the fixes to the race condition in the bulk indexer and you will need to merge your changes again. @gburgett

@gburgett
Copy link
Author

Thanks, unfortunately I'm no longer a member of the Concur organization. @ryan-bunker should be able to finish out this pull request.

Levi Corcoran added 3 commits October 12, 2015 15:18
…t, until they are fully sent and any errors are reported, to ensure proper shutdown sequencing
# Conflicts:
#	lib/baserequest.go
#	lib/corebulk.go
#	lib/corebulk_test.go
#	lib/coreexample_test.go
#	lib/coretest_test.go
#	lib/request.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants