Revert workaround for puma 4.1.0 output bug #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Puma 4.1.0 had a bug where its output was not properly detached prior to daemonizing. To work around this, I added output redirection to the `bundle exec puma` command to force the output to be detached from the console. Now that puma has fixed this bug, I am removing the output redirection. The redirection had a downside: it hid messages from the console that were valuable for troubleshooting. For example if puma had an invalid config file that prevented it from starting, the error would have been hidden. To avoid a breaking change, I am keeping the `:puma_stdout_path` and `:puma_stderr_path` tomo settings around. But rather than using them for output direction, they will be passed to puma's `--redirect-stdout` and `--redirect-stderr` options. These also redirect puma's output, but _after_ puma has successfully been started and daemonized (i.e after tomo's deploy has finished).
|
Waiting for puma 4.1.1 to be released before merging. ⏳ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puma 4.1.0 had a bug (puma/puma#1906) where its output was not properly detached prior to daemonizing. To work around this, I added output redirection to the
bundle exec pumacommand to force the output to be detached from the console (see #39).Now that puma has fixed this bug, I am removing the output redirection. The redirection had a downside: it hid messages from the console that were valuable for troubleshooting. For example if puma had an invalid config file that prevented it from starting, the error would have been hidden.
To avoid a breaking change, I am keeping the
:puma_stdout_pathand:puma_stderr_pathtomo settings around. But rather than using them for output direction, they will be passed to puma's--redirect-stdoutand--redirect-stderroptions. These also redirect puma's output, but after puma has successfully been started and daemonized (i.e after tomo's deploy has finished).