Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add req to defaultIndex args #199

Merged
merged 1 commit into from
Feb 13, 2017
Merged

Add req to defaultIndex args #199

merged 1 commit into from
Feb 13, 2017

Conversation

rreusser
Copy link
Contributor

@rreusser rreusser commented Feb 9, 2017

The API docs for defaultIndex state the format of a custom function as fn(params, req), so either I'm misinterpreting the docs or it's missing req so that the actual call is just fn(params). This PR adds the req argument and a corresponding test. Thanks for your time!

Notes:

  • current invocation is here
  • simple-html-index ignores the second argument, so hopefully shouldn't be a breaking change (though could certainly just skip passing it to that)

@mattdesl mattdesl merged commit ef8151b into mattdesl:master Feb 13, 2017
@mattdesl
Copy link
Owner

Nice catch! Thanks. 😄

@rreusser rreusser deleted the add-req-to-default-index-args branch February 13, 2017 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants