feat(sc): improved bytecode compression validity checks #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benceharomi
requested review from
vladbochok and
StanislavBreadless
as code owners
6 tasks
vladbochok
reviewed
Feb 27, 2024
vladbochok
reviewed
Mar 1, 2024
vladbochok
reviewed
Mar 1, 2024
…optimal-compression-for-bytecodes # Conflicts: # l1-contracts/scripts/deploy-erc20.ts
…optimal-compression-for-bytecodes
…optimal-compression-for-bytecodes
vladbochok
approved these changes
Mar 5, 2024
…optimal-compression-for-bytecodes
vladbochok
deleted the
bh-evm-321-enforce-correct-relatively-optimal-compression-for-bytecodes
branch
github-merge-queue bot
pushed a commit
to matter-labs/zksync-era
that referenced
this pull request
Apr 18, 2024
## What ❔ Updated the bytecode compression explanation example, to be valid and working. In the connecting contracts PR: matter-labs/era-contracts#193 I added a test that checks the bytecode and runs the `publishCompressBytecode` function with the bytecode from this example. ## Why ❔ The previous example was not valid, it could confuse newcomers, because the example had different bytecode compared to what was described. ## Checklist - [x] PR title corresponds to the body of PR (we generate changelog entries from PRs). - [x] Tests for the changes have been added / updated. - [x] Documentation comments have been added / updated. - [x] Code has been formatted via `zk fmt` and `zk lint`. - [x] Spellcheck has been run via `zk spellcheck`. - [x] Linkcheck has been run via `zk linkcheck`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Improved the
publishCompressedBytecodefunction to have better compressed bytecode validity checks.Now it also reverts if there are more dictionary entries than encoded data entries.
Created a connecting PR that fixes the example found in the documentation that explains bytecode compression: matter-labs/zksync-era#1013
Why ❔
We would like to assure that the operators are not able to consume all of the gas payed by the user without receiving any execution.
Checklist