Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create separate CI jobs #24

Merged
merged 8 commits into from
Sep 18, 2023
Merged

Create separate CI jobs #24

merged 8 commits into from
Sep 18, 2023

Conversation

benceharomi
Copy link
Contributor

@benceharomi benceharomi commented Sep 15, 2023 •
edited
Loading

  • build and test have been split to two separate CI jobs
  • Configs added/updated for EditorConfig, Prettier and Solhint to enforce standardised formatting and linting
  • Linting script added to the package.json
  • Created a lint CI job that runs in parallel with build
  • Linted all Solidity files in the ethereum directory:
    • the linting of the Solidity files happened with an automated tool (prettier)
    • prettier is not formatting too long comments and imports, these were wrapped/skipped manually
  • Added max-warnings as an upper limit to restrict introducing new warnings

@benceharomi benceharomi force-pushed the bh-evm-260-create-separate-ci-jobs branch from 5ba7204 to 300bf9e Compare September 18, 2023 08:46
mm-zk
mm-zk approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@mm-zk mm-zk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future - please clearly mark in PR description, that all solidity changes were done with automated tool.

@benceharomi benceharomi force-pushed the bh-evm-260-create-separate-ci-jobs branch 2 times, most recently from 2352c52 to ac3536d Compare September 18, 2023 11:55
@benceharomi benceharomi force-pushed the bh-evm-260-create-separate-ci-jobs branch from ac3536d to 81a7eaa Compare September 18, 2023 12:24
@benceharomi
Copy link
Contributor Author

For future - please clearly mark in PR description, that all solidity changes were done with automated tool.

Description modified

@benceharomi benceharomi merged commit 3c385c7 into dev Sep 18, 2023
5 checks passed
@benceharomi benceharomi deleted the bh-evm-260-create-separate-ci-jobs branch September 18, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yorik yorik yorik left review comments

@vladbochok vladbochok vladbochok approved these changes

@mm-zk mm-zk mm-zk approved these changes

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless StanislavBreadless is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benceharomi @yorik @vladbochok @mm-zk