Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download commond in Dockerfile #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0x-stan
Copy link

@0x-stan 0x-stan commented Mar 21, 2024

What πŸ’»

  • remove echo to fix download commond in Dockerfile
    • RUN curl -s echo "https://api.github.com/... -> RUN curl -s "https://api.github.com/...

Why βœ‹

  • Using curl -s echo can cause the jq -r command to fail, but removing the echo command allows it to execute correctly. The current version of the Dockerfile will cause the build to fail; after modification, it can be built successfully.
# will faild with echo
curl -s echo "https://api.github.com/repos/matter-labs/era-test-node/releases/tags/v0.1.0-alpha.19" | jq -r
jq: parse error: Invalid numeric literal at line 1, column 10

# query successfully
curl -s "https://api.github.com/repos/matter-labs/era-test-node/releases/tags/v0.1.0-alpha.19" | jq -r
{
  "url": "https://api.github.com/repos/matter-labs/era-test-node/releases/147603455",
  "assets_url": "https://api.github.com/repos/matter-labs/era-test-node/releases/147603455/assets",
  "upload_url": "https://uploads.github.com/repos/matter-labs/era-test-node/releases/147603455/assets{?name,label}",
  ...
}

Evidence πŸ“·

image

Local Development Environment:

Operating System: macOs Ventura 13.3
Node.js Version: 20.11.0
npm Version: 10.5.0
Docker Version: 24.0.2
curl Version: 7.87.0
jq Version: jq-1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant