Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replacing 1.3.3 test harness with circuit sequencer api #1382

Merged
merged 1 commit into from
Mar 7, 2024
Merged

feat: replacing 1.3.3 test harness with circuit sequencer api #1382

merged 1 commit into from
Mar 7, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Mar 7, 2024

What ❔

  • replacing full 1.3.3 test harness, with a smaller crate (circuit_sequencer_api), that just contains the needed functions.
  • using a simplified generic type (FinalProof) for the final proof (and added a test)

Why ❔

  • This allows us to include less things when compiling the sequencer code, leading to faster compilation times.

@mm-zk mm-zk requested a review from popzxc March 7, 2024 11:15
@mm-zk mm-zk enabled auto-merge March 7, 2024 11:19
@mm-zk mm-zk added this pull request to the merge queue Mar 7, 2024
Merged via the queue into main with commit a628d56 Mar 7, 2024
36 of 37 checks passed
@mm-zk mm-zk deleted the mmzk_0307_replace_133 branch March 7, 2024 12:06
This was referenced Mar 7, 2024
Merged
Merged
RomanBrodetski pushed a commit that referenced this pull request Mar 12, 2024
@zksync-era-bot
chore(main): release prover 12.1.0 (#1363)
1d3edab 
🤖 I have created a release *beep* *boop*
---


##
[12.1.0](prover-v12.0.1...prover-v12.1.0)
(2024-03-12)


### Features

* add run-observability to zk
([#1359](#1359))
([2b520f6](2b520f6))
* block revert support for consensus component
([#1213](#1213))
([8a3a938](8a3a938))
* enhance unit test for batch tip
([#1253](#1253))
([ca7d194](ca7d194))
* Moving 1.4.x to use the circuit_api
([#1383](#1383))
([8add2d6](8add2d6))
* **prover:** Fixing snark verification keys
([#1225](#1225))
([5cbef73](5cbef73))
* replacing 1.3.3 test harness with circuit sequencer api
([#1382](#1382))
([a628d56](a628d56))
* Start using a new test harness interface without generics
([#1378](#1378))
([1e431a6](1e431a6))


### Bug Fixes

* **api:** SQL: use = instead of ANY where possible in events-related
queries ([#1346](#1346))
([160b4d4](160b4d4))
* Updated Verification keys
([#1414](#1414))
([66667d2](66667d2))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot pushed a commit that referenced this pull request Mar 13, 2024
@zksync-era-bot
chore(main): release core 21.1.0 (#1332)
cd748e9 
🤖 I have created a release *beep* *boop*
---


##
[21.1.0](core-v21.0.0...core-v21.1.0)
(2024-03-13)


### Features

* **api:** Monitor server RPC errors
([#1203](#1203))
([60d1060](60d1060))
* block revert support for consensus component
([#1213](#1213))
([8a3a938](8a3a938))
* **db:** Add Postgres table size metrics
([#1351](#1351))
([63f3ff8](63f3ff8))
* **db:** Serialize events queue as bytes
([#1420](#1420))
([955680b](955680b))
* enabled loading yaml config for the main node
([#1344](#1344))
([0adab9e](0adab9e))
* **en:** Enable Merkle tree client on EN
([#1386](#1386))
([58576d1](58576d1))
* enhance unit test for batch tip
([#1253](#1253))
([ca7d194](ca7d194))
* Moving 1.4.x to use the circuit_api
([#1383](#1383))
([8add2d6](8add2d6))
* **node_framework:** Add timeouts for remaining tasks to avoid hang
outs ([#1354](#1354))
([8108dbd](8108dbd))
* **node-framework:** Add commitment generator layer
([#1402](#1402))
([daa029c](daa029c))
* replacing 1.3.3 test harness with circuit sequencer api
([#1382](#1382))
([a628d56](a628d56))


### Bug Fixes

* **aggregator:** correct order of processing of prove transactions
([#1333](#1333))
([7522d15](7522d15))
* **api:** Fix panics in API server if storage values cache is disabled
([#1370](#1370))
([723232b](723232b))
* **api:** SQL: use = instead of ANY where possible in events-related
queries ([#1346](#1346))
([160b4d4](160b4d4))
* **consistency_checker:** Fix consistency checker for large pubdata
([#1331](#1331))
([d162add](d162add))
* **en:** Fix pending transactions subscription
([#1342](#1342))
([a040001](a040001))
* **eth-sender:** adjust the blob tx fees taking into account the
current prices
([#1399](#1399))
([fea67fb](fea67fb))
* **gas-adjuster:** Do not unwrap in gas-adjuster
([#1400](#1400))
([269812e](269812e))
* **gas-adjuster:** Use `internal_pubdata_pricing_multiplier` for
pubdata price calculation
([#1404](#1404))
([a40c2d0](a40c2d0))


### Performance Improvements

* **db:** Add "contains" clause for get_logs
([#1384](#1384))
([e62ae32](e62ae32))
* **db:** Remove obsolete indexes
([#1376](#1376))
([0afc377](0afc377))


### Reverts

* **db:** Remove "contains" clause for get_logs
([#1384](#1384))
([#1407](#1407))
([1da53f3](1da53f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mm-zk @popzxc