Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new commitments #219

Merged
merged 7 commits into from
Oct 17, 2023

Conversation

perekopskiy
Copy link
Contributor

@perekopskiy perekopskiy commented Oct 13, 2023

What ❔

  • events_queue_commitment and bootloader_initial_content_commitment are calculated in full tree and saved into DB.
  • nightly rust is used
  • lints found by clippy are fixed

Why ❔

Preparation for boojum upgrade

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@perekopskiy perekopskiy changed the title feat: Add new commitments [WIP] feat: Add new commitments Oct 13, 2023
@perekopskiy perekopskiy force-pushed the perekopskiy-pla-621-add-events_queue_commitment branch from a046301 to d7809d1 Compare October 13, 2023 12:12
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (26ee1fb) 32.27% compared to head (a9620d9) 32.73%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #219      +/-   ##
==========================================
+ Coverage   32.27%   32.73%   +0.45%     
==========================================
  Files         535      534       -1     
  Lines       28297    27818     -479     
==========================================
- Hits         9133     9105      -28     
+ Misses      19164    18713     -451     
Files Coverage Δ
core/lib/dal/src/models/storage_block.rs 75.67% <100.00%> (+0.22%) ⬆️
core/lib/dal/src/storage_logs_dal.rs 78.52% <ø> (-0.49%) ⬇️
core/lib/merkle_tree/src/storage/patch.rs 80.23% <100.00%> (-1.58%) ⬇️
core/lib/types/src/commitment.rs 71.73% <ø> (-1.46%) ⬇️
core/lib/types/src/priority_op_onchain_data.rs 0.00% <ø> (ø)
core/lib/zksync_core/src/genesis.rs 94.82% <100.00%> (+0.04%) ⬆️
...lib/zksync_core/src/metadata_calculator/helpers.rs 89.47% <100.00%> (+4.66%) ⬆️
...lib/zksync_core/src/metadata_calculator/metrics.rs 92.30% <ø> (ø)
...ore/lib/zksync_core/src/metadata_calculator/mod.rs 89.58% <ø> (+1.58%) ⬆️
.../lib/zksync_core/src/state_keeper/io/seal_logic.rs 81.78% <ø> (+1.62%) ⬆️
... and 10 more

... and 281 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/lib/types/src/block.rs Outdated Show resolved Hide resolved
@perekopskiy perekopskiy force-pushed the perekopskiy-pla-621-add-events_queue_commitment branch from 43d0c0d to 2d7c93c Compare October 16, 2023 08:50
@perekopskiy perekopskiy changed the title [WIP] feat: Add new commitments feat: Add new commitments Oct 16, 2023
@perekopskiy perekopskiy marked this pull request as ready for review October 16, 2023 10:24
@perekopskiy perekopskiy requested a review from a team as a code owner October 16, 2023 10:24
perekopskiy and others added 2 commits October 16, 2023 15:41
Co-authored-by: Stanislav Bezkorovainyi <stanislavbezkor@gmail.com>
@github-actions
Copy link
Contributor

Detected VM performance changes

Benchmark name Difference in runtime
slot_hash_collision -4.6%
write_and_decode -5.1%
access_memory -3.9%
decode_shl_sub -4.8%
event_spam -3.1%

@perekopskiy perekopskiy added this pull request to the merge queue Oct 17, 2023
Merged via the queue into main with commit a19256e Oct 17, 2023
25 checks passed
@perekopskiy perekopskiy deleted the perekopskiy-pla-621-add-events_queue_commitment branch October 17, 2023 08:16
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.1.0](core-v16.0.2...core-v16.1.0)
(2023-10-24)


### Features

* Add new commitments
([#219](#219))
([a19256e](a19256e))
* arm64 zk-environment rust Docker images and other
([#296](#296))
([33174aa](33174aa))
* **config:** Extract everything not related to the env config from
zksync_config crate
([#245](#245))
([42c64e9](42c64e9))
* **eth-watch:** process governor upgrades
([#247](#247))
([d250294](d250294))
* **merkle tree:** Expose Merkle tree API
([#209](#209))
([4010c7e](4010c7e))
* **merkle tree:** Snapshot recovery for Merkle tree
([#163](#163))
([9e20703](9e20703))
* **multivm:** Remove lifetime from multivm
([#218](#218))
([7eda27c](7eda27c))
* Remove fee_ticker and token_trading_volume fetcher modules
([#262](#262))
([44f7179](44f7179))
* **reorg_detector:** compare miniblock hashes for reorg detection
([#236](#236))
([2c930b2](2c930b2))
* Rewrite server binary to use `vise` metrics
([#120](#120))
([26ee1fb](26ee1fb))
* **types:** introduce state diff record type and compression
([#194](#194))
([ccf753c](ccf753c))
* **vm:** Improve tracer trait
([#121](#121))
([ff60138](ff60138))
* **vm:** Move all vm versions to the one crate
([#249](#249))
([e3fb489](e3fb489))


### Bug Fixes

* **crypto:** update snark-vk to be used in server and update args for
proof wrapping
([#240](#240))
([4a5c54c](4a5c54c))
* **db:** Fix write stalls in RocksDB
([#250](#250))
([650124c](650124c))
* **db:** Fix write stalls in RocksDB (again)
([#265](#265))
([7b23ab0](7b23ab0))
* **db:** Fix write stalls in RocksDB (for real this time)
([#292](#292))
([0f15919](0f15919))
* Fix `TxStage` string representation
([#255](#255))
([246b5a0](246b5a0))
* fix typos
([#226](#226))
([feb8a6c](feb8a6c))
* **witness-generator:** Witness generator oracle with cached storage
refunds ([#274](#274))
([8928a41](8928a41))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants