Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): introduce state diff record type and compression #194

Merged
merged 18 commits into from
Oct 16, 2023

Conversation

koloz193
Copy link
Contributor

@koloz193 koloz193 commented Oct 11, 2023

What ❔

Introduces the StateDiffRecord type and advanced compression for this type.

Why ❔

In boojum, all storage writes will be replaced with StateDiffRecord types. In order to cut down on the number of bytes published to L1 we want to compress this data as much as possible.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@koloz193 koloz193 requested a review from mm-zk October 11, 2023 14:29
@koloz193 koloz193 requested a review from a team as a code owner October 11, 2023 14:29
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 47 lines in your changes are missing coverage. Please review.

Comparison is base (39788b6) 32.26% compared to head (cda55ba) 32.35%.
Report is 2 commits behind head on main.

❗ Current head cda55ba differs from pull request most recent head a2c6f8f. Consider uploading reports for the commit a2c6f8f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   32.26%   32.35%   +0.08%     
==========================================
  Files         535      537       +2     
  Lines       28299    28400     +101     
==========================================
+ Hits         9132     9189      +57     
- Misses      19167    19211      +44     
Files Coverage Δ
core/lib/types/src/storage/writes/mod.rs 60.00% <60.00%> (ø)
core/lib/types/src/storage/writes/compression.rs 47.61% <47.61%> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/lib/types/src/storage/writes/compression.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/compression.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/compression.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/compression.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Outdated Show resolved Hide resolved
core/lib/types/src/storage/writes/mod.rs Show resolved Hide resolved
mm-zk
mm-zk previously approved these changes Oct 13, 2023
core/lib/types/src/storage/writes/compression.rs Outdated Show resolved Hide resolved
@koloz193 koloz193 requested a review from mm-zk October 13, 2023 16:21
mm-zk
mm-zk previously approved these changes Oct 16, 2023
@koloz193 koloz193 added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit ccf753c Oct 16, 2023
22 checks passed
@koloz193 koloz193 deleted the zk-pubdata-compression branch October 16, 2023 12:46
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.1.0](core-v16.0.2...core-v16.1.0)
(2023-10-24)


### Features

* Add new commitments
([#219](#219))
([a19256e](a19256e))
* arm64 zk-environment rust Docker images and other
([#296](#296))
([33174aa](33174aa))
* **config:** Extract everything not related to the env config from
zksync_config crate
([#245](#245))
([42c64e9](42c64e9))
* **eth-watch:** process governor upgrades
([#247](#247))
([d250294](d250294))
* **merkle tree:** Expose Merkle tree API
([#209](#209))
([4010c7e](4010c7e))
* **merkle tree:** Snapshot recovery for Merkle tree
([#163](#163))
([9e20703](9e20703))
* **multivm:** Remove lifetime from multivm
([#218](#218))
([7eda27c](7eda27c))
* Remove fee_ticker and token_trading_volume fetcher modules
([#262](#262))
([44f7179](44f7179))
* **reorg_detector:** compare miniblock hashes for reorg detection
([#236](#236))
([2c930b2](2c930b2))
* Rewrite server binary to use `vise` metrics
([#120](#120))
([26ee1fb](26ee1fb))
* **types:** introduce state diff record type and compression
([#194](#194))
([ccf753c](ccf753c))
* **vm:** Improve tracer trait
([#121](#121))
([ff60138](ff60138))
* **vm:** Move all vm versions to the one crate
([#249](#249))
([e3fb489](e3fb489))


### Bug Fixes

* **crypto:** update snark-vk to be used in server and update args for
proof wrapping
([#240](#240))
([4a5c54c](4a5c54c))
* **db:** Fix write stalls in RocksDB
([#250](#250))
([650124c](650124c))
* **db:** Fix write stalls in RocksDB (again)
([#265](#265))
([7b23ab0](7b23ab0))
* **db:** Fix write stalls in RocksDB (for real this time)
([#292](#292))
([0f15919](0f15919))
* Fix `TxStage` string representation
([#255](#255))
([246b5a0](246b5a0))
* fix typos
([#226](#226))
([feb8a6c](feb8a6c))
* **witness-generator:** Witness generator oracle with cached storage
refunds ([#274](#274))
([8928a41](8928a41))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants