Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: arm64 zk-environment rust Docker images and other #296

Merged
merged 25 commits into from
Oct 24, 2023
Merged

Conversation

hatemosphere
Copy link
Member

@hatemosphere hatemosphere commented Oct 23, 2023

What ❔

  • Bump zksolc and zksvyper binaries, build solidity from source (to support arm64 in future)
  • Minor CI and Dockerfiles refactoring here and there
  • Bump ancient gcloud CLI in zk-env publish CI
  • Bump Ubuntu in zk-env to 22.04
  • Build zk-environment (non-CUDA) on arm64

Why ❔

To unblock building of the core services on arm64 arch

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0e5eefc) 35.58% compared to head (44ef73b) 35.58%.
Report is 5 commits behind head on main.

❗ Current head 44ef73b differs from pull request most recent head bfe702a. Consider uploading reports for the commit bfe702a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #296      +/-   ##
==========================================
- Coverage   35.58%   35.58%   -0.01%     
==========================================
  Files         520      520              
  Lines       28336    28336              
==========================================
- Hits        10084    10082       -2     
- Misses      18252    18254       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hatemosphere hatemosphere changed the title ci: arm64 zk-environment rust Docker images feat: arm64 zk-environment rust Docker images Oct 24, 2023
@hatemosphere hatemosphere changed the title feat: arm64 zk-environment rust Docker images ci: arm64 zk-environment rust Docker images Oct 24, 2023
@hatemosphere hatemosphere changed the title ci: arm64 zk-environment rust Docker images ci: arm64 zk-environment rust Docker images and other Oct 24, 2023
@hatemosphere hatemosphere marked this pull request as ready for review October 24, 2023 08:25
otani88
otani88 previously approved these changes Oct 24, 2023
.github/workflows/ci-core-reusable.yml Show resolved Hide resolved
yorik
yorik previously approved these changes Oct 24, 2023
docker/contract-verifier/Dockerfile Show resolved Hide resolved
sqlx_v0.5.13.patch Outdated Show resolved Hide resolved
@hatemosphere hatemosphere changed the title ci: arm64 zk-environment rust Docker images and other feat: arm64 zk-environment rust Docker images and other Oct 24, 2023
@hatemosphere hatemosphere dismissed stale reviews from yorik and otani88 via 96ba3f6 October 24, 2023 08:37
popzxc
popzxc previously approved these changes Oct 24, 2023
@hatemosphere hatemosphere dismissed alexandrst88’s stale review October 24, 2023 08:45

de-hardcoding compiler versions in pipeline and ts tests should be tackled separately

perekopskiy
perekopskiy previously approved these changes Oct 24, 2023
@hatemosphere hatemosphere dismissed stale reviews from perekopskiy and popzxc via bfe702a October 24, 2023 08:52
@hatemosphere hatemosphere added this pull request to the merge queue Oct 24, 2023
Merged via the queue into main with commit 33174aa Oct 24, 2023
25 of 27 checks passed
@hatemosphere hatemosphere deleted the zk-env-arm branch October 24, 2023 09:33
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2023
🤖 I have created a release *beep* *boop*
---


##
[16.1.0](core-v16.0.2...core-v16.1.0)
(2023-10-24)


### Features

* Add new commitments
([#219](#219))
([a19256e](a19256e))
* arm64 zk-environment rust Docker images and other
([#296](#296))
([33174aa](33174aa))
* **config:** Extract everything not related to the env config from
zksync_config crate
([#245](#245))
([42c64e9](42c64e9))
* **eth-watch:** process governor upgrades
([#247](#247))
([d250294](d250294))
* **merkle tree:** Expose Merkle tree API
([#209](#209))
([4010c7e](4010c7e))
* **merkle tree:** Snapshot recovery for Merkle tree
([#163](#163))
([9e20703](9e20703))
* **multivm:** Remove lifetime from multivm
([#218](#218))
([7eda27c](7eda27c))
* Remove fee_ticker and token_trading_volume fetcher modules
([#262](#262))
([44f7179](44f7179))
* **reorg_detector:** compare miniblock hashes for reorg detection
([#236](#236))
([2c930b2](2c930b2))
* Rewrite server binary to use `vise` metrics
([#120](#120))
([26ee1fb](26ee1fb))
* **types:** introduce state diff record type and compression
([#194](#194))
([ccf753c](ccf753c))
* **vm:** Improve tracer trait
([#121](#121))
([ff60138](ff60138))
* **vm:** Move all vm versions to the one crate
([#249](#249))
([e3fb489](e3fb489))


### Bug Fixes

* **crypto:** update snark-vk to be used in server and update args for
proof wrapping
([#240](#240))
([4a5c54c](4a5c54c))
* **db:** Fix write stalls in RocksDB
([#250](#250))
([650124c](650124c))
* **db:** Fix write stalls in RocksDB (again)
([#265](#265))
([7b23ab0](7b23ab0))
* **db:** Fix write stalls in RocksDB (for real this time)
([#292](#292))
([0f15919](0f15919))
* Fix `TxStage` string representation
([#255](#255))
([246b5a0](246b5a0))
* fix typos
([#226](#226))
([feb8a6c](feb8a6c))
* **witness-generator:** Witness generator oracle with cached storage
refunds ([#274](#274))
([8928a41](8928a41))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants