feat(eth-watch): process governor upgrades #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤜👍🤝 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #247 +/- ##
==========================================
+ Coverage 32.82% 32.93% +0.11%
==========================================
Files 536 537 +1
Lines 27908 28015 +107
==========================================
+ Hits 9160 9226 +66
- Misses 18748 18789 +41
☔ View full report in Codecov by Sentry. |
Deniallugo
reviewed
Oct 17, 2023
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Show resolved
Hide resolved
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Show resolved
Hide resolved
mm-zk
requested changes
Oct 17, 2023
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Show resolved
Hide resolved
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Outdated
Show resolved
Hide resolved
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Show resolved
Hide resolved
mm-zk
reviewed
Oct 18, 2023
core/lib/zksync_core/src/eth_watch/event_processors/governance_upgrades.rs
Show resolved
Hide resolved
Deniallugo
approved these changes
Oct 19, 2023
mm-zk
approved these changes
Oct 19, 2023
perekopskiy
deleted the
perekopskiy-pla-627-move-eth-sender-and-eth-watcher-boojum-diff-to-main
branch
vladbochok
reviewed
Oct 23, 2023
| diamond_proxy_address, | ||
| last_seen_version_id, | ||
| upgrade_proposal_signature: governance_contract | ||
| .event("TransparentOperationScheduled") |
There was a problem hiding this comment.
Please create a follow-up task to support ShadowOperationScheduled
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
🤖 I have created a release *beep* *boop* --- ## [16.1.0](core-v16.0.2...core-v16.1.0) (2023-10-24) ### Features * Add new commitments ([#219](#219)) ([a19256e](a19256e)) * arm64 zk-environment rust Docker images and other ([#296](#296)) ([33174aa](33174aa)) * **config:** Extract everything not related to the env config from zksync_config crate ([#245](#245)) ([42c64e9](42c64e9)) * **eth-watch:** process governor upgrades ([#247](#247)) ([d250294](d250294)) * **merkle tree:** Expose Merkle tree API ([#209](#209)) ([4010c7e](4010c7e)) * **merkle tree:** Snapshot recovery for Merkle tree ([#163](#163)) ([9e20703](9e20703)) * **multivm:** Remove lifetime from multivm ([#218](#218)) ([7eda27c](7eda27c)) * Remove fee_ticker and token_trading_volume fetcher modules ([#262](#262)) ([44f7179](44f7179)) * **reorg_detector:** compare miniblock hashes for reorg detection ([#236](#236)) ([2c930b2](2c930b2)) * Rewrite server binary to use `vise` metrics ([#120](#120)) ([26ee1fb](26ee1fb)) * **types:** introduce state diff record type and compression ([#194](#194)) ([ccf753c](ccf753c)) * **vm:** Improve tracer trait ([#121](#121)) ([ff60138](ff60138)) * **vm:** Move all vm versions to the one crate ([#249](#249)) ([e3fb489](e3fb489)) ### Bug Fixes * **crypto:** update snark-vk to be used in server and update args for proof wrapping ([#240](#240)) ([4a5c54c](4a5c54c)) * **db:** Fix write stalls in RocksDB ([#250](#250)) ([650124c](650124c)) * **db:** Fix write stalls in RocksDB (again) ([#265](#265)) ([7b23ab0](7b23ab0)) * **db:** Fix write stalls in RocksDB (for real this time) ([#292](#292)) ([0f15919](0f15919)) * Fix `TxStage` string representation ([#255](#255)) ([246b5a0](246b5a0)) * fix typos ([#226](#226)) ([feb8a6c](feb8a6c)) * **witness-generator:** Witness generator oracle with cached storage refunds ([#274](#274)) ([8928a41](8928a41)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
With boojum upgrades will go through governor. PR adds functionality to process such upgrades while leaving old processor as well.
Why ❔
Prepare for boojum upgrade
Checklist
zk fmtandzk lint.