Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Added KZG info needed for 4844 blobs #894

Merged
merged 40 commits into from
Feb 7, 2024
Merged

feat(types): Added KZG info needed for 4844 blobs #894

merged 40 commits into from
Feb 7, 2024

Conversation

koloz193
Copy link
Contributor

@koloz193 koloz193 commented Jan 17, 2024 •
edited

What ❔

In order to support blobs we need to transform our pubdata into kzg commitments and compute opening/proofs to be used within our contracts/for blob transactions.

Why ❔

This will allow us to take full advantage of 4844 blobs.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.

koloz193
koloz193 commented Jan 17, 2024
View reviewed changes
core/lib/types/Cargo.toml Outdated Show resolved Hide resolved
StanislavBreadless
StanislavBreadless reviewed Jan 18, 2024
View reviewed changes
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
Base automatically changed from sb-short-term-fee-model-1-4-1 to main January 18, 2024 17:26
@koloz193 koloz193 changed the title Added KZG info needed for 4844 blobs feat(types): Added KZG info needed for 4844 blobs Jan 19, 2024
StanislavBreadless
StanislavBreadless reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@StanislavBreadless StanislavBreadless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
mm-zk
mm-zk previously requested changes Jan 23, 2024
View reviewed changes
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
core/lib/types/src/kzg.rs Outdated Show resolved Hide resolved
@koloz193 koloz193 requested a review from popzxc January 31, 2024 21:18
popzxc
popzxc reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comments are mostly about the form, not about the actual implementation.

core/lib/l1_contract_interface/Cargo.toml Outdated Show resolved Hide resolved
core/lib/l1_contract_interface/Cargo.toml Outdated Show resolved Hide resolved
core/lib/l1_contract_interface/src/i_executor/commit/kzg.rs Outdated Show resolved Hide resolved
core/lib/l1_contract_interface/src/i_executor/commit/kzg.rs Show resolved Hide resolved
core/lib/l1_contract_interface/src/i_executor/commit/kzg.rs Outdated Show resolved Hide resolved
core/lib/l1_contract_interface/src/lib.rs Outdated Show resolved Hide resolved
popzxc
popzxc reviewed Feb 6, 2024
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
@koloz193 koloz193 added this pull request to the merge queue Feb 7, 2024
Merged via the queue into main with commit 758f487 Feb 7, 2024
37 checks passed
@koloz193 koloz193 deleted the zk-4844-kzg-info branch February 7, 2024 13:33
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 7, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Feb 8, 2024
@zksync-era-bot
chore(main): release core 20.6.0 (#1011)
689d38c 
🤖 I have created a release *beep* *boop*
---


##
[20.6.0](core-v20.5.2...core-v20.6.0)
(2024-02-08)


### Features

* **api:** Start API server after first L1 batch
([#1026](#1026))
([86e189c](86e189c))
* **db:** Instrument DB connection lifecycle
([#1027](#1027))
([636fcfd](636fcfd))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Make state keeper work with pruned data
([#900](#900))
([f1913ae](f1913ae))
* export fee model for the test node
([#1030](#1030))
([d1e4774](d1e4774))
* Time-limit health checks and log them
([#993](#993))
([f3c190d](f3c190d))
* **types:** Added KZG info needed for 4844 blobs
([#894](#894))
([758f487](758f487))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* **metrics:** Use latest block for non pos ethereum as safe
([#1022](#1022))
([49ec843](49ec843))
* Revert "preparation for shared bridge migration (server)"
([#1010](#1010))
([d4c984a](d4c984a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montekki montekki montekki approved these changes

@shamatar shamatar Awaiting requested review from shamatar

@mm-zk mm-zk Awaiting requested review from mm-zk

@Deniallugo Deniallugo Awaiting requested review from Deniallugo

@StanislavBreadless StanislavBreadless Awaiting requested review from StanislavBreadless

@jules jules Awaiting requested review from jules

@popzxc popzxc Awaiting requested review from popzxc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@koloz193 @montekki @shamatar @Deniallugo @popzxc @jules @StanislavBreadless @mm-zk