feat(en): Make state keeper work with pruned data #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
force-pushed
the
aov-pla-703-snapshot-recovery-make-state-keeper-work-with-pruned-data
branch
from
1a31b74
to
ef8bbc2
Compare
slowli
commented
Jan 19, 2024
5 tasks
RomanBrodetski
previously approved these changes
Jan 31, 2024
There was a problem hiding this comment.
looks really good. For the amount of changes in invariants, I expected worse changes are needed on the code level.
Like the L1BatchParamsProvider abstraction. I don't see a good way around it.
Are the new invariants documented anywhere? Like, what can programmer rely on when writing code that runs agains our DB? Something like:
- there are no gaps in miniblock/l1 batch indices
- if miniblock #N is missing, there is a snapshot with miniblock >N
Separately, would Main Node work with pruned data? I don't see why not.
Right now it won't because some components only run on the main node would need to be adapted to support snapshot recovery. Such adaptation seems straightforward though. |
…per-work-with-pruned-data
slowli
commented
Feb 1, 2024
RomanBrodetski
previously approved these changes
Feb 1, 2024
slowli
force-pushed
the
aov-pla-703-snapshot-recovery-make-state-keeper-work-with-pruned-data
branch
from
42967bc
to
fac593f
Compare
RomanBrodetski
approved these changes
Feb 6, 2024
slowli
deleted the
aov-pla-703-snapshot-recovery-make-state-keeper-work-with-pruned-data
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 8, 2024
🤖 I have created a release *beep* *boop* --- ## [20.6.0](core-v20.5.2...core-v20.6.0) (2024-02-08) ### Features * **api:** Start API server after first L1 batch ([#1026](#1026)) ([86e189c](86e189c)) * **db:** Instrument DB connection lifecycle ([#1027](#1027)) ([636fcfd](636fcfd)) * **db:** Soft-remove `storage` table ([#982](#982)) ([601f893](601f893)) * **en:** Make state keeper work with pruned data ([#900](#900)) ([f1913ae](f1913ae)) * export fee model for the test node ([#1030](#1030)) ([d1e4774](d1e4774)) * Time-limit health checks and log them ([#993](#993)) ([f3c190d](f3c190d)) * **types:** Added KZG info needed for 4844 blobs ([#894](#894)) ([758f487](758f487)) ### Bug Fixes * fix link ([#1007](#1007)) ([f1424ce](f1424ce)) * **metrics:** Use latest block for non pos ethereum as safe ([#1022](#1022)) ([49ec843](49ec843)) * Revert "preparation for shared bridge migration (server)" ([#1010](#1010)) ([d4c984a](d4c984a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Modifies state keeper so that it works with pruned node data during snapshot recovery.
Why ❔
Part of preparations of EN code to support snapshot recovery.
Checklist
zk fmtandzk lint.zk spellcheck.