Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improving verification key generation #1050

Merged
merged 7 commits into from
Feb 15, 2024
Merged

feat: improving verification key generation #1050

merged 7 commits into from
Feb 15, 2024

Conversation

mm-zk
Copy link
Collaborator

@mm-zk mm-zk commented Feb 13, 2024 •
edited
Loading

What ❔

  • Removed vk_generator.rs that was no longer used
  • Added more logging to VK generation
  • Added an early check to detect if CRS file is missing

Why ❔

  • vk_generator logic code is already present in witness_generator crate
  • more logging helps to see what is happening
  • early check saves people 30 minutes, if they didn't configure their setup correctly.

@mm-zk mm-zk requested a review from EmilLuta February 13, 2024 15:46
@mm-zk mm-zk marked this pull request as ready for review February 13, 2024 15:46
@mm-zk mm-zk changed the title DONOTSUBMIT: improving key generation chore: improving verification key generation Feb 13, 2024
@RomanBrodetski
Copy link
Collaborator

@mm-zk why chore? You don't want this to appear in the Changelog? THat's what Chore does

@mm-zk mm-zk changed the title chore: improving verification key generation feat: improving verification key generation Feb 15, 2024
@mm-zk
Copy link
Collaborator Author

mm-zk commented Feb 15, 2024

@RomanBrodetski - good point. Updated to feat.

EmilLuta
EmilLuta previously approved these changes Feb 15, 2024
View reviewed changes
@mm-zk mm-zk requested a review from EmilLuta February 15, 2024 15:14
EmilLuta
EmilLuta previously approved these changes Feb 15, 2024
View reviewed changes
EmilLuta
EmilLuta previously approved these changes Feb 15, 2024
View reviewed changes
@mm-zk mm-zk enabled auto-merge February 15, 2024 16:34
@mm-zk mm-zk added this pull request to the merge queue Feb 15, 2024
Merged via the queue into main with commit 6f715c8 Feb 15, 2024
25 checks passed
@mm-zk mm-zk deleted the mmzk0213_better_print branch February 15, 2024 16:56
@zksync-era-bot zksync-era-bot mentioned this pull request Feb 15, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Mar 5, 2024
@zksync-era-bot
chore(main): release prover 12.0.0 (#970)
7b54689 
🤖 I have created a release *beep* *boop*
---


##
[12.0.0](prover-v11.0.0...prover-v12.0.0)
(2024-03-04)


### ⚠ BREAKING CHANGES

* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
* Set 21 as latest protocol version
([#1262](#1262))

### Features

* Adding ability to generate 4844 setup key and refactor
([#1143](#1143))
([975f54b](975f54b))
* **api:** Remove unused and obsolete token info
([#1071](#1071))
([e920897](e920897))
* **dal:** `zksync_types::Transaction` to use protobuf for wire encoding
(BFT-407)
([#1047](#1047))
([ee94bee](ee94bee))
* **db:** Soft-remove `storage` table
([#982](#982))
([601f893](601f893))
* **en:** Integrate snapshots recovery into EN
([#1032](#1032))
([c7cfaf9](c7cfaf9))
* **healthcheck:** Various healthcheck improvements
([#1166](#1166))
([1e34148](1e34148))
* improving verification key generation
([#1050](#1050))
([6f715c8](6f715c8))
* Prover interface and L1 interface crates
([#959](#959))
([4f7e107](4f7e107))
* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
([6953e89](6953e89))
* **prover:** Added --recompute-if-missing option to key generator
([#1151](#1151))
([cad7278](cad7278))
* **prover:** Added 4844 circuit to verification keys
([#1141](#1141))
([8b0cc4a](8b0cc4a))
* **prover:** Adding first support for 4844 circuit
([#1155](#1155))
([6f63c53](6f63c53))
* **prover:** adding keystore object to handle reading and writing of
prover keys
([#1132](#1132))
([1471615](1471615))
* **prover:** merging key generation into a single binary
([#1101](#1101))
([6de8b84](6de8b84))
* **prover:** Moved setup key generation logic to test harness
([#1113](#1113))
([469ab06](469ab06))
* **prover:** Use new shivini function for 4844 circuits
([#1205](#1205))
([376c09e](376c09e))
* Set 21 as latest protocol version
([#1262](#1262))
([30579ef](30579ef))
* **vlog:** Remove env getters from vlog
([#1077](#1077))
([00d3429](00d3429))


### Bug Fixes

* fix link
([#1007](#1007))
([f1424ce](f1424ce))
* make `zk status prover` use the new prover table
([#1044](#1044))
([9b21d7f](9b21d7f))
* **prover:** Decouple core/ prover database management
([#1029](#1029))
([37674fd](37674fd))
* **prover:** Fix initial prover migration
([#1083](#1083))
([6d54010](6d54010))
* **prover:** QoL socket utilization
([#1020](#1020))
([13a6816](13a6816))
* update harness to include fix to new boojum OOM
([#1053](#1053))
([4976941](4976941))


### Performance Improvements

* bump harness version
([#1003](#1003))
([1cbb4c9](1cbb4c9))
* reduce memory consumption of witness generation
([#696](#696))
([dea6768](dea6768))
* upgrade harness version to improve witness generation memory spike
([#1034](#1034))
([09bbb84](09bbb84))
* use jemalloc in witness generator
([#1014](#1014))
([917b2dc](917b2dc))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shamatar shamatar shamatar left review comments

@EmilLuta EmilLuta EmilLuta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mm-zk @RomanBrodetski @shamatar @EmilLuta