Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gas-adjuster): gas adjuster for EIP4844 #1255

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Conversation

perekopskiy
Copy link
Contributor

What ❔

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via zk spellcheck.
  • Linkcheck has been run via zk linkcheck.

@perekopskiy perekopskiy changed the title WIP: gas adjuster for EIP4844 feat(gas-adjuster): gas adjuster for EIP4844 Feb 27, 2024
@perekopskiy perekopskiy marked this pull request as ready for review February 27, 2024 11:08
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, but it's a shame that web3 is unmaintained and we didn't switch to ethers.

@montekki
Copy link
Member

and we didn't switch to ethers.

@popzxc ethers is also unmaintained and does not support 4844.

@popzxc
Copy link
Member

popzxc commented Feb 27, 2024

@montekki we need our own fork then :harold2:
Last time I've checked alloy or how is it called now, it was heavily WIP and I doubt that it's ready to be used in production.

@perekopskiy perekopskiy added this pull request to the merge queue Feb 28, 2024
Merged via the queue into main with commit 1da97ed Feb 28, 2024
29 checks passed
@perekopskiy perekopskiy deleted the eip4844-gas-adjuster branch February 28, 2024 09:49
moshababo pushed a commit that referenced this pull request Feb 28, 2024
## What ❔

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted via `zk fmt` and `zk lint`.
- [ ] Spellcheck has been run via `zk spellcheck`.
- [ ] Linkcheck has been run via `zk linkcheck`.

---------

Co-authored-by: Fedor Sakharov <fedor.sakharov@gmail.com>
RomanBrodetski pushed a commit that referenced this pull request Mar 1, 2024
🤖 I have created a release *beep* *boop*
---


##
[21.0.0](core-v20.8.0...core-v21.0.0)
(2024-03-01)


### ⚠ BREAKING CHANGES

* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
* Set 21 as latest protocol version
([#1262](#1262))

### Features

* A way to disable slow query logging for some queries
([#1297](#1297))
([13b82a0](13b82a0))
* **aggregator:** support two operator addresses in sender and
aggregator
([#1201](#1201))
([7be56e5](7be56e5))
* change EN main node fetcher concurrency factor
([#1317](#1317))
([d4235b5](d4235b5))
* **commitment-generator:** Commitment for 1.4.2
([#1234](#1234))
([9b773eb](9b773eb))
* **config:** add pubdata sending method to config
([#1261](#1261))
([cebf55a](cebf55a))
* **config:** Added blobs to commit batches and made da source part of
config ([#1243](#1243))
([e01d1b6](e01d1b6))
* **config:** update eth_sender to use blobs
([#1295](#1295))
([e81f080](e81f080))
* **core:** Adds support for 4844 transaction signing and rlp encoding
([#1254](#1254))
([10e3a3e](10e3a3e))
* **dal:** `zksync_types::Transaction` to use protobuf for wire encoding
(BFT-407)
([#1047](#1047))
([ee94bee](ee94bee))
* **eth_sender:** set blob gas fee when blobs DA is used
([#1285](#1285))
([57c5526](57c5526))
* **gas-adjuster:** gas adjuster for EIP4844
([#1255](#1255))
([1da97ed](1da97ed))
* Metrics for block tip
([#1144](#1144))
([85d4b12](85d4b12))
* **node_framework:** Add Web3 API layers
([#1258](#1258))
([105f4cc](105f4cc))
* **node_framework:** Support Proof Data Handler in the framework
([#1233](#1233))
([2191218](2191218))
* **prover:** Add EIP4844 support for provers subsystem
([#1200](#1200))
([6953e89](6953e89))
* Remove methods to sign an arbitraty message
([#1294](#1294))
([8904123](8904123))
* Set 21 as latest protocol version
([#1262](#1262))
([30579ef](30579ef))
* support loading verifier and protocol version from db
([#1293](#1293))
([533f013](533f013))


### Bug Fixes

* Add EIP4844 to fri_prover_group_config
([#1309](#1309))
([edf9397](edf9397))
* **api:** Use better gas per pubdata in API (pure server changes)
([#1311](#1311))
([54f8d8c](54f8d8c))
* **docker:** change default password for postgres
([#1250](#1250))
([f6bff74](f6bff74))
* **en:** fail fast if we don't request correct number of txs from man
node ([#1269](#1269))
([1bcbf17](1bcbf17))
* Fix scheduler enqueuer bug
([#1322](#1322))
([95deb92](95deb92))
* **snapshots_creator:** Fix snapshot generation query
([#1289](#1289))
([e279456](e279456))
* **vm:** fix match clause in `get_max_gas_per_pubdata_byte`
([#1292](#1292))
([eaf5a50](eaf5a50))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants