feat(node_framework): Add Web3 API layers #1258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
changed the title
popzxc
force-pushed
the
popzxc-api-layer
branch
from
cf618a5
to
e3f9617
Compare
popzxc
commented
Feb 28, 2024
core/node/node_framework/src/implementations/layers/web3_api/db_tx_sink.rs
Outdated
Show resolved
Hide resolved
slowli
reviewed
Feb 29, 2024
core/node/node_framework/src/implementations/layers/web3_api/server.rs
Outdated
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/web3_api/tx_sender.rs
Show resolved
Hide resolved
core/node/node_framework/src/implementations/layers/web3_api/tx_sender.rs
Show resolved
Hide resolved
core/node/node_framework/src/implementations/resources/pools.rs
Outdated
Show resolved
Hide resolved
|
Well, that's unexpected 😅 |
popzxc
requested review from
yorik,
alexandrst88,
artmakh,
hatemosphere,
onyxet and
otani88
No performance difference detected (anymore) |
slowli
approved these changes
Mar 1, 2024
hatemosphere
approved these changes
Mar 1, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
RomanBrodetski
pushed a commit
that referenced
this pull request
Mar 1, 2024
🤖 I have created a release *beep* *boop* --- ## [21.0.0](core-v20.8.0...core-v21.0.0) (2024-03-01) ### ⚠ BREAKING CHANGES * **prover:** Add EIP4844 support for provers subsystem ([#1200](#1200)) * Set 21 as latest protocol version ([#1262](#1262)) ### Features * A way to disable slow query logging for some queries ([#1297](#1297)) ([13b82a0](13b82a0)) * **aggregator:** support two operator addresses in sender and aggregator ([#1201](#1201)) ([7be56e5](7be56e5)) * change EN main node fetcher concurrency factor ([#1317](#1317)) ([d4235b5](d4235b5)) * **commitment-generator:** Commitment for 1.4.2 ([#1234](#1234)) ([9b773eb](9b773eb)) * **config:** add pubdata sending method to config ([#1261](#1261)) ([cebf55a](cebf55a)) * **config:** Added blobs to commit batches and made da source part of config ([#1243](#1243)) ([e01d1b6](e01d1b6)) * **config:** update eth_sender to use blobs ([#1295](#1295)) ([e81f080](e81f080)) * **core:** Adds support for 4844 transaction signing and rlp encoding ([#1254](#1254)) ([10e3a3e](10e3a3e)) * **dal:** `zksync_types::Transaction` to use protobuf for wire encoding (BFT-407) ([#1047](#1047)) ([ee94bee](ee94bee)) * **eth_sender:** set blob gas fee when blobs DA is used ([#1285](#1285)) ([57c5526](57c5526)) * **gas-adjuster:** gas adjuster for EIP4844 ([#1255](#1255)) ([1da97ed](1da97ed)) * Metrics for block tip ([#1144](#1144)) ([85d4b12](85d4b12)) * **node_framework:** Add Web3 API layers ([#1258](#1258)) ([105f4cc](105f4cc)) * **node_framework:** Support Proof Data Handler in the framework ([#1233](#1233)) ([2191218](2191218)) * **prover:** Add EIP4844 support for provers subsystem ([#1200](#1200)) ([6953e89](6953e89)) * Remove methods to sign an arbitraty message ([#1294](#1294)) ([8904123](8904123)) * Set 21 as latest protocol version ([#1262](#1262)) ([30579ef](30579ef)) * support loading verifier and protocol version from db ([#1293](#1293)) ([533f013](533f013)) ### Bug Fixes * Add EIP4844 to fri_prover_group_config ([#1309](#1309)) ([edf9397](edf9397)) * **api:** Use better gas per pubdata in API (pure server changes) ([#1311](#1311)) ([54f8d8c](54f8d8c)) * **docker:** change default password for postgres ([#1250](#1250)) ([f6bff74](f6bff74)) * **en:** fail fast if we don't request correct number of txs from man node ([#1269](#1269)) ([1bcbf17](1bcbf17)) * Fix scheduler enqueuer bug ([#1322](#1322)) ([95deb92](95deb92)) * **snapshots_creator:** Fix snapshot generation query ([#1289](#1289)) ([e279456](e279456)) * **vm:** fix match clause in `get_max_gas_per_pubdata_byte` ([#1292](#1292)) ([eaf5a50](eaf5a50)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With some hacks, adds support of our Web3 API to the framework.
For more context on hacks/tradeoffs, see comments in the PR.
With this PR, the node finally passes a significant number of tests. Once the
eth_senderis migrated, I expect all the tests to pass.