feat: Implemented 1 validator consensus for the main node #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slowli
reviewed
Nov 28, 2023
pompon0
force-pushed
the
gprusak-consensus2
branch
from
7fcd1cd
to
32e478a
Compare
slowli
reviewed
Dec 7, 2023
pompon0
added a commit
to matter-labs/era-consensus
that referenced
this pull request
Dec 7, 2023
We need a way to delegate proposing/verifying the block's payload to the user. See the related pr: matter-labs/zksync-era#554 Additionally introduced stronger typing for signed messages in bft tests. Fixes BFT-388.
slowli
previously approved these changes
Dec 11, 2023
…sync-era into gprusak-consensus2
brunoffranca
previously approved these changes
Dec 11, 2023
brunoffranca
previously approved these changes
Dec 12, 2023
brunoffranca
approved these changes
Dec 12, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 13, 2023
🤖 I have created a release *beep* *boop* --- ## [18.8.0](core-v18.7.0...core-v18.8.0) (2023-12-13) ### Features * **api:** Sunset API translator ([#675](#675)) ([846fd33](846fd33)) * **core:** Merge bounded and unbounded gas adjuster ([#678](#678)) ([f3c3bf5](f3c3bf5)) * **dal:** Make ConnectionPoolBuilder owned ([#676](#676)) ([1153c42](1153c42)) * Implemented 1 validator consensus for the main node ([#554](#554)) ([9c59838](9c59838)) * **merkle tree:** Snapshot recovery in metadata calculator ([#607](#607)) ([f49418b](f49418b)) ### Bug Fixes * dropping installed filters ([#670](#670)) ([985c737](985c737)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Implemented 1 validator consensus for the main node.
It is NOT enabled yet, corresponding configuration still needs to be provided.
It is responsible for populating consensus column in the Miniblocks table.
Consensus will be running asynchronously for now, not affecting the miniblock production at all.
Fixes BFT-388.
Why ❔
Reaching a consensus with just 1 validator doesn't provide much value, however we want to start running the consensus code in production (in a "shadow" mode) to make sure it works as expected before we start relying on it.