Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 1.5.0 #62

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Bump version to 1.5.0 #62

merged 2 commits into from
Sep 20, 2022

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented Sep 6, 2022

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 6, 2022
@DHaussermann
Copy link

@mickmister is it possible a file change was missed here?

Building from thins branch still has the old version stamp on the binary for me. not sure if I'm missing something but despite your changes it's now shoeing and the new version when compiled and uploaded.
image

plugin.json Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #62 (fe9cb9a) into master (6b0a636) will not change coverage.
The diff coverage is n/a.

❗ Current head fe9cb9a differs from pull request most recent head 1a2ffd4. Consider uploading reports for the commit 1a2ffd4 to get more accurate results

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   80.02%   80.02%           
=======================================
  Files           3        3           
  Lines        1537     1537           
=======================================
  Hits         1230     1230           
  Misses        184      184           
  Partials      123      123           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mickmister
Copy link
Contributor Author

@DHaussermann The version issue is fixed now 👍

@DHaussermann DHaussermann removed the 2: Dev Review Requires review by a core committer label Sep 8, 2022
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Sep 13, 2022
@hanzei hanzei removed their request for review September 17, 2022 18:15
@hanzei hanzei added this to the v1.5.0 milestone Sep 20, 2022
@hanzei hanzei assigned hanzei and unassigned mickmister Sep 20, 2022
@hanzei hanzei merged commit 37aef0b into master Sep 20, 2022
@hanzei hanzei deleted the release-bump-1.5.0 branch September 20, 2022 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants