Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison should be case in-sensitive #12

Merged
merged 5 commits into from
May 17, 2020

Conversation

bbuehrle
Copy link
Contributor

All words to be filtered should be lower-case, regardless of how entered. Word to be compared should be lower-case, regardless of how entered.

All words to be filtered should be lower-case, regardless of how entered.  Word to be compared should be lower-case, regardless of how entered
string => strings
Completely new to Go
@bbuehrle
Copy link
Contributor Author

bbuehrle commented May 14, 2020

I completely wing-ed this. I'm not sure yet how to add any test to check if this works, but point me in the right direction and I can try to add that as well.

Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Unfortunately there aren't any tests yet, so it's fine to merge is as it is.

@hanzei hanzei requested a review from iomodo May 14, 2020 17:42
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 14, 2020
@hanzei hanzei linked an issue May 16, 2020 that may be closed by this pull request
@hanzei hanzei mentioned this pull request May 16, 2020
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bbuehrle ! LGTM!

@iomodo iomodo merged commit 55f49a5 into mattermost-community:master May 17, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 18, 2020
@hanzei hanzei added this to the v0.2.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Case sensitivity
3 participants