Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comparison should ignore accents #10

Merged
merged 1 commit into from
May 27, 2020
Merged

Comparison should ignore accents #10

merged 1 commit into from
May 27, 2020

Conversation

nathanaelhoun
Copy link
Contributor

@nathanaelhoun nathanaelhoun commented Apr 27, 2020 •
edited
Loading

Summary

  • For a better support of non-English languages, comparison recognise naughty words even if they contain accents.

Ticket Link

/

@hanzei hanzei self-requested a review April 27, 2020 13:43
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Apr 27, 2020
hanzei
hanzei suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improvising this plugin!

The change look good, but the panic worries be a bit.

server/plugin.go Outdated Show resolved Hide resolved
@hanzei hanzei added the 3: QA Review Requires review by a QA tester label Apr 27, 2020
@nathanaelhoun nathanaelhoun marked this pull request as draft April 30, 2020 16:24
@nathanaelhoun nathanaelhoun marked this pull request as ready for review May 2, 2020 21:30
hanzei
hanzei approved these changes May 3, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanzei hanzei requested a review from iomodo May 3, 2020 06:11
iomodo
iomodo suggested changes May 6, 2020
View reviewed changes
Copy link

@iomodo iomodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution @nathanaelhoun. Can we add some unit tests please?

@nathanaelhoun
Copy link
Contributor Author

Thanks ! Can I add the unit test, and if so, how ? I am still discovering your workflow :-)

@nathanaelhoun
Copy link
Contributor Author

There is a minor conflict because #12 also implements case insensivity

@nathanaelhoun nathanaelhoun changed the title Detect naughty words with caps or accents Comparison should ignore accents May 26, 2020
@nathanaelhoun
Copy link
Contributor Author

nathanaelhoun commented May 26, 2020 •
edited
Loading

I haved rebased from master to resolve the conflict (#12 having implemented the same thing) and squashed my change in a single commit.
Sorry to have sent so much changes, I am still discovering git :-)

Let me know if you need another changes

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 27, 2020
@hanzei
Copy link
Contributor

hanzei commented May 27, 2020

All fine @nathanaelhoun, the PR is ready to go!

@hanzei hanzei merged commit 26f4491 into mattermost-community:master May 27, 2020
@hanzei hanzei added this to the v0.2.0 milestone May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iomodo iomodo iomodo requested changes

@hanzei hanzei hanzei approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nathanaelhoun @hanzei @iomodo