Allows using * to configure the welcome message for all teams

[maisnamrajusingh]

Summary

Allows using * to configure the welcome message for all teams

Ticket Link

#36

[mattermod]

Hello @maisnamrajusingh,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

[hanzei]

The implementation is fine for "*".

The original ticket discussed adding support for Globbing in general and allow patterns like qa-team-*. Can this be implemented in a reasonable amount of time and without adding much complexity?

[maisnamrajusingh]

@hanzei I think it adds more complexity to the code base, there is already another pr that would let users use "team-1,team2" etc to allow the message for multiple teams. But let me know if you feel I should look into it

[hanzei]

How would the /welcomebot preview command work with this feature?

[hanzei]

@aaronrothschild I would love to hear your thoughts on the Globbing discussion above.

[aaronrothschild]

From the original ticket "however, i would like to be able to send people a welcome-message after their first login - regardless of the team they join."

To me, there are multiple things at play here:

• Adding the config for multiple teams vs "all" teams is two different settings IMO. ie: []allusers? or [x,y,z] teams?
• The root issue: Send a user message WHEN THEY JOIN THE SERVER - regardless of team membership really. This is "welcomebot" so, I think it makes sense to have a different/setting message for "All New Users, on any team" (ie: a "Server Welcome Message"). The admin doesn't really want the user to see the message every time they join a team (I think) - they just want to make sure a new user sees a message when they join the server, regardless of which team. Imagine joining 5 teams and seeing the same welcome message each time - because we added this "globbing" setting, would happen a bunch more IMO. (correct me if the behavior is different than I'm describing)
• When someone, at some point adds another team tot he server....does the "*" mean it affects ALL teams or "ALL teams in place when the welcomebot was configured last"? ie: Will an admin need to remember to add the Team to the setting in welcomebot so a user will see the welcome message if they join that new team? That presents a maintenance issue.

@hanzei

[jasonblais]

@hanzei on above

[hanzei]

@maisnamrajusingh #80 (review) still seems unresolved.

[hanzei]

Thanks for your thoughts @aaronrothschild. Based on that feedback the PR needs to get updated so the welcome message triggers at user creation not team joining.

[mattermod]

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

/cc @jasonblais @jfrerich @emilyacook

[maisnamrajusingh]

@hanzei I assumed this ticket doesn't need to be worked on because of a misunderstanding I had when I spoke to @mickmister I'll look into this now

[maisnamrajusingh]

@aaronrothschild @hanzei so looking at the comments. Does the following make sense

1. we would add a specific field called "GlobalMessage" that would look something like this

"GlobalWelcomeMessage": "Global Welcome Message"

2. hook into the UserHasJoinedServer ( I am assuming something like this exists) to display the message.

[aaronrothschild]

@maisnamrajusingh Yes, that sounds correct to me. Thanks!

[mickmister]

I assumed this ticket doesn't need to be worked on because of a misunderstanding I had when I spoke to @mickmister I'll look into this now

Just to surface the miscommunication here, the original message I posted said "Note that the welcomebot App project should not be worked at the moment". I was referring specifically to this ticket #42 (comment), which is decided to be implemented as a Mattermost App.

The Welcomebot plugin should continue to be developed and improved. Sorry for this miscommunication.

[hanzei]

I doesn't seem like like #80 (comment) gets addressed in this PR, does it?

[maisnamrajusingh]

I doesn't seem like like #80 (comment) gets addressed in this PR, does it?

@hanzei using the * would produce a maintainence issue as mentioned in the comment and confirmed here
#80 (comment)

[hanzei]

@maisnamrajusingh I don't understand what are you referring to. @mickmister talked in #80 (comment) about the possible conversion from a plugin to an app. IMO this doesn't impact this ticket at all, does it? The suggestion you made in #80 (comment) still seems reasonable to me and I would like to see that feature.

[ayusht2810]

@mickmister @hanzei @aaronrothschild We looked into the above comments and thought of an approach.
We will be adding a new field in the config GlobalWelcomeMessage to support the welcome message when a user has joined a server. Currently, we don't have any hooks present in the mattermost, which triggers when a user joins a sever, so we will be using the UserHasBeenCreated hook to post the message as soon as the user is created in the welcome bot DM.
Also, there is an edge case here: if an admin adds a config with both GlobalWelcomeMessage and TeamName (with the mattermost teamname present), we will give preference to posting the per team message in the welcome bot DM.
What are your thoughts on this approach? Let me know if I am missing something here.

[mickmister]

Also, there is an edge case here: if an admin adds a config with both GlobalWelcomeMessage and TeamName (with the mattermost teamname present), we will give preference to posting the per team message in the welcome bot DM. What are your thoughts on this approach? Let me know if I am missing something here.

@ayusht2810 I'm thinking we should create posts for both the global and per-team in this case

[ayusht2810]

Created PR #131 according to the above comments

[raghavaggarwal2308]

Closing because of #131