Update action to exit when msg is empty #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanzei
approved these changes
Jan 15, 2020
| github.com/pkg/errors v0.9.0 | ||
| go.uber.org/zap v1.13.0 // indirect | ||
| golang.org/x/crypto v0.0.0-20200109152110-61a87790db17 // indirect | ||
| gopkg.in/yaml.v2 v2.2.7 // indirect |
There was a problem hiding this comment.
How did you generate the file? Are the indirect imports needed?
There was a problem hiding this comment.
i can build it again
| go 1.13 | ||
|
|
||
| require ( | ||
| github.com/mattermost/mattermost-server/v5 v5.3.2-0.20200114132950-e77ef9733c97 |
There was a problem hiding this comment.
How did you generate this line? I was expecting it to look like https://github.com/mattermost/mattermost-plugin-jira/blob/master/go.mod#L11
lieut-data
approved these changes
Jan 15, 2020
hanzei
added
3: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if Text or Attachments are empty exit without failing
first part to fix mattermost/mattermost-developer-documentation#496 (comment)