Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-52857 - Update types #13

Merged
merged 2 commits into from
Jun 12, 2023
Merged

MM-52857 - Update types #13

merged 2 commits into from
Jun 12, 2023

Conversation

cpoile
Copy link
Member

@cpoile cpoile commented Jun 8, 2023

@cpoile cpoile added the 2: Dev Review Requires review by a core committer label Jun 8, 2023
@cpoile cpoile requested a review from streamer45 June 8, 2023 21:00
streamer45
streamer45 reviewed Jun 9, 2023
View reviewed changes
lib/types/types.d.ts Outdated Show resolved Hide resolved
@cpoile cpoile requested a review from streamer45 June 12, 2023 15:37
streamer45
streamer45 approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@streamer45 streamer45 added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jun 12, 2023
@cpoile cpoile merged commit 304c9db into master Jun 12, 2023
4 checks passed
@cpoile cpoile deleted the MM-52857-dm-ringing branch June 12, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cpoile @streamer45