Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect task name in Windows 10 startup list #559

Closed
3 tasks done
jasonblais opened this issue Jul 10, 2017 · 6 comments
Closed
3 tasks done

Incorrect task name in Windows 10 startup list #559

jasonblais opened this issue Jul 10, 2017 · 6 comments

Comments

@jasonblais
Copy link
Contributor

jasonblais commented Jul 10, 2017

I confirm (by marking "x" in the [ ] below):


Ticket: https://mattermost.atlassian.net/browse/MM-14095

See original report: #542

When Mattermost App is set to be launched at startup, the task manager displays an incorrect name or publisher name.

Steps to reproduce

  1. Set Mattermost Windows App to start with Windows.
  2. Launch Windows Task Manager (CTRL+ALT+SUPRR)
  3. Select Startup Tab
  4. Mattermost App is under a group named Update(X) and the Publisher is GitHub

capture2

Expected behavior

Instead of Update the name of the process should be Mattermost (same for Publisher)

Possible fixes

Run rcedit when packaging Windows app and find the code in electron-builder to modify the process name.

@yuya-oc
Copy link
Contributor

yuya-oc commented Jul 28, 2017

I made a PR for electron-builder, however it's rejected. It seems that we should not change the meta data.

@jasonblais
Copy link
Contributor Author

Hm, is there a workaround we can do on our end?

@yuya-oc
Copy link
Contributor

yuya-oc commented Jul 28, 2017

There is possiblity, but I think it's difficult.

  1. Extract a packaged installer.
  2. Modify metadata of Update.exe.
  3. Re-package into a new installer.

As suggested in the PR, it might be good for us to use nsis installer (#491). And we can also get electron-builder's support for auto-updater I'm investigating

@jasonblais
Copy link
Contributor Author

Oh that's nice. Sounds good.

I think we can leave this ticket for now and work on it at the same time when we get to #491.

If it doesn't work, we can consider the alternate option, but I agree it sounds difficult.

@jasonblais jasonblais modified the milestones: v3.9.0, v3.8.0 Jul 28, 2017
@jasonblais jasonblais removed the Hacktoberfest null label Nov 3, 2017
@amyblais amyblais removed this from the v4.1.0 milestone Mar 21, 2018
@amyblais amyblais added the Hackfest null label Jan 25, 2019
@amyblais
Copy link
Member

Jira ticket for tracking: https://mattermost.atlassian.net/browse/MM-14095

@amyblais amyblais changed the title Incorrect task name in Windows 10 startup list [Help Wanted] Incorrect task name in Windows 10 startup list Feb 27, 2019
@amyblais amyblais removed the Hackfest null label Mar 1, 2019
@amyblais amyblais added the Hacktoberfest null label Oct 7, 2019
@hanzei hanzei changed the title [Help Wanted] Incorrect task name in Windows 10 startup list Incorrect task name in Windows 10 startup list Oct 22, 2019
@amyblais amyblais removed the Hacktoberfest null label Nov 4, 2019
@esethna
Copy link
Contributor

esethna commented Mar 25, 2020

No longer valid with v4.4

@esethna esethna closed this as completed Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants