Manually handle misbehaving keyboard shortcuts #1092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MM-19198 MM-19032 includes zooming, redo/undo & copy/cut/paste for good measure
deanwhillier
added
2: Dev Review
devinbinnie
approved these changes
Oct 28, 2019
deanwhillier
added
the
4: Reviews Complete
|
@deanwhillier |
deanwhillier
added a commit
that referenced
this pull request
Nov 20, 2019
* manually handle misbehaving keyboard shortcuts MM-19198 MM-19032 includes zooming, redo/undo & copy/cut/paste for good measure * manually handle misbehaving menu items * bump electron minor version * remove temp log import * update context menu package version
3 tasks
amyblais
added
CherryPick/Done
|
When will this fix make it into the desktop app? |
|
I found that it breaks Ctrl-c/Ctrl-v on Windows 10 at least, see #1118. |
JtheBAB
pushed a commit
to JtheBAB/desktop
that referenced
this pull request
Jan 17, 2020
* manually handle misbehaving keyboard shortcuts MM-19198 MM-19032 includes zooming, redo/undo & copy/cut/paste for good measure * manually handle misbehaving menu items * bump electron minor version * remove temp log import * update context menu package version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting, please confirm you've
npm run lint:jsfor proper code formattingPlease provide the following information:
Summary
There are a number of menu bar keyboard shortcuts that have not been working properly since 4.3.0. We suspect that this may be related to https://community-daily.mattermost.com/core/pl/b95bi44r4bbnueqzjjxsi46qiw. While we investigate a proper way to handle the issue, this PR manually intercepts and handles several of the malfunctioning keyboard shortcuts including zooming, redo/undo. Copy/cut/paste are included for good measure.
Also bumps minor version of Electron to v5.0.11 and upgrades context menu package to latest stable to resolve https://mattermost.atlassian.net/browse/MM-19324 (needs testing).
Issue link
MM-19198
MM-19032
MM-19324