Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MM-20627: Create SECURITY.md #1145

Merged
merged 4 commits into from Jan 9, 2020
Merged

MM-20627: Create SECURITY.md #1145

merged 4 commits into from Jan 9, 2020

Conversation

jupenur
Copy link
Member

@jupenur jupenur commented Jan 6, 2020

Before submitting, please confirm you've

Please provide the following information:

Summary
Create a security policy document for GitHub.

Issue link
https://mattermost.atlassian.net/browse/MM-20627

Test Cases

Additional Notes

@jupenur jupenur changed the title Create SECURITY.md MM-20627: Create SECURITY.md Jan 6, 2020
@DSchalla DSchalla requested review from Willyfrog and removed request for deanwhillier January 6, 2020 14:34
@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Jan 7, 2020
Willyfrog
Willyfrog approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@Willyfrog Willyfrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking good, one improvement could be to add a check to the issue template so people "have to" tick and read that what they are writing is not a security issue, as most people won't go any further than the report button.

other than that, looks good

@Willyfrog
Copy link
Contributor

you can find the templates here: https://github.com/mattermost/desktop/tree/master/.github/ISSUE_TEMPLATE

@jupenur
Copy link
Member Author

jupenur commented Jan 8, 2020

Copied over some minor changes from the server repo.

@jupenur jupenur requested a review from Willyfrog January 8, 2020 13:55
@Willyfrog
Copy link
Contributor

seems you don't have access to the signing contexts, I'll rerun the tests (although not really neccessary)

@jupenur jupenur merged commit df95af5 into master Jan 9, 2020
@jupenur jupenur deleted the MM-20627 branch January 9, 2020 09:41
@jupenur jupenur added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Jan 9, 2020
JtheBAB pushed a commit to JtheBAB/desktop that referenced this pull request Jan 17, 2020
@jupenur @JtheBAB
MM-20627: Create SECURITY.md (mattermost#1145)
d456f34 
* Create SECURITY.md

* Add missing updates section to SECURITY.md

* Fix typo in SECURITY.md

* Update wording in SECURITY.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willyfrog Willyfrog Willyfrog approved these changes

@DSchalla DSchalla DSchalla approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jupenur @Willyfrog @DSchalla @hanzei