Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a few resizing issues #2703

Merged
merged 6 commits into from May 3, 2023
Merged

Fixed a few resizing issues #2703

merged 6 commits into from May 3, 2023

Conversation

devinbinnie
Copy link
Member

Summary

A few of the weird resizing cases showed up again after the refactor, I've made fixes for them:

  • macOS; Fixed the issue where rapidly resizing cues up a bunch of changes to the BrowserViews and keeps it bouncing back and forth
  • Linux: Fixed the issue where maximizing/full-screening doesn't resize the window properly
  • Windows: Ensured that users with 'Show window contents while dragging" is off will still be able to resize.
NONE

@devinbinnie devinbinnie added the 2: Dev Review Requires review by a core committer label May 2, 2023
@cpoile cpoile requested review from streamer45 and removed request for cpoile May 2, 2023 21:34
@cpoile
Copy link
Member

cpoile commented May 2, 2023

Claudio should take a look at this, I know he's been looking at it recently.

streamer45
streamer45 approved these changes May 3, 2023
View reviewed changes
Copy link
Contributor

@streamer45 streamer45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devinbinnie devinbinnie merged commit 1049b07 into mattermost:master May 3, 2023
12 checks passed
@amyblais amyblais added this to the v6.0.0 milestone May 3, 2023
@devinbinnie devinbinnie mentioned this pull request May 4, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@streamer45 streamer45 streamer45 approved these changes

@M-ZubairAhmed M-ZubairAhmed M-ZubairAhmed approved these changes

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer release-note-none
Projects
None yet
Milestone
v5.4.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@devinbinnie @cpoile @streamer45 @M-ZubairAhmed @amyblais @mm-cloud-bot