[MM-55317] Force deep linking to use formatted path names when rewriting the URL #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-ZubairAhmed
approved these changes
Nov 9, 2023
hmhealey
requested changes
Nov 9, 2023
hmhealey
approved these changes
Nov 10, 2023
devinbinnie
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When deep linking, we were re-writing the path incorrect by not removing the trailing slash for servers with subpaths. This was causing issues with the Desktop App's auth flow.
This PR fixes the deep linking flow to make sure to clean the subpath properly.
Ticket Link
https://mattermost.atlassian.net/browse/MM-55317
Closes #2906