Update NOTICE.txt #867
Update NOTICE.txt #867
Conversation
- Add new dependencies (react-dom) - Update homepage and project owner info for all dependencies - Add SPDX open-source license IDs
|
|
||
| * HOMEPAGE: | ||
| * https://github.com/sindresorhus/electron-context-menu | ||
| * https://github.com/sindresorhus/electron-context-menu#readme |
There was a problem hiding this comment.
Curious why #readme is attached as part of the URL (similarly in a few other places)
|
|
||
| * HOMEPAGE: | ||
| * https://github.com/mongodb-js/electron-squirrel-startup | ||
| * http://github.com/mongodb-js/electron-squirrel-startup |
|
Hi @jasonblais - the "Homepage" URLs are taken directly from the package registry entries made by their respective authors, e.g. https://www.npmjs.com/package/electron-context-menu If you mouse over the "homepage" at right you will see the I considered applying an automatic clean-up to these URLs, but hesitate to over-ride any settings made by the project author. For now, which of the following would you prefer?
(long-term, as a separate effort, I will be reaching out to dependency authors to help them fix problems with URLs, licenses, and ownership data on their own projects. Today's pull requests reflect a best effort given the data currently available on NPM and GitHub). |
|
I see. I agree with your assessment that we should respect the exact homepage URL provided by the author. Hence, option 1 sounds good to me. Thank you @danmaas! |
|
The current update follows option 1 as discussed above. I've re-run the automation against this repo, including the "modified version of..." logic we discussed here, and there are no new changes. |
|
Thank you all! Merging |
@danmaas Is the automation committed to somewhere as something like a script? Once it's committed, we can reuse it when we update dependencies. |
|
Hi @yuya-oc - I'm working on a GitHub app that will take care of these NOTICE updates automatically. From now until the app is available, I'll be sending manual updates monthly (or upon request). |
Summary
Update NOTICE.txt with latest open-source license info
Additional Notes
This follows the recent NOTICE.txt update to
mattermost-server, PR here: mattermost/mattermost#9433The only difference is that this is an NPM-based project, so the dependency manifest is created by listing the "dependencies" section of all
package.jsonfiles.Linebreak/whitespace changes in this PR are to match the original LICENSE files supplied with each dependency. This is a one-time change that will make future automated updates smaller.