Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-57909] Remove single-handler support for Calls #7154

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Conversation

streamer45
Copy link
Contributor

Summary

We are fully deprecating this mode in Calls v0.28, shipping with Mattermost v9.10

Ticket Link

https://mattermost.atlassian.net/browse/MM-57909

@streamer45 streamer45 added 1: Dev Review Requires review by a core commiter Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) labels May 23, 2024
@streamer45 streamer45 requested a review from cpoile May 23, 2024 22:49
@streamer45 streamer45 self-assigned this May 23, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 0136ab5

1 similar comment
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 0136ab5

Copy link
Member

@cpoile cpoile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This command will output information (i.e. source and destination addresses) for all the network packets being sent or received through port ``8443``. This is a good way to check whether data is getting in and out of the instance and can be used to quickly identify network configuration issues.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, why is this line marked as modified?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a new line or white space, not sure.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷

@cpoile cpoile added 3: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels May 29, 2024
@amyblais amyblais added this to the v9.10.0 milestone May 31, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA 3be72c1

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 5c8d193

Copy link

Newest code from mattermost has been published to preview environment for Git SHA 899c820

@amyblais amyblais removed the Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) label Jul 16, 2024
Copy link

Newest code from mattermost has been published to preview environment for Git SHA b9cabb6

@amyblais amyblais added Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) and removed Do Not Merge/Awaiting Next Release To be merged with the next release (e.g. API documentation updates) labels Jul 16, 2024
@amyblais amyblais merged commit 83990ad into master Jul 16, 2024
4 checks passed
@amyblais amyblais deleted the MM-57909 branch July 16, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants