Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test TestField_Map #47

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix flaky test TestField_Map #47

merged 1 commit into from
Nov 23, 2023

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Nov 23, 2023

Summary

#46 added a flaky test. The element order of MapRange() is not defined and can vary from run to run.

Ticket Link

#46

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Nov 23, 2023
@hanzei hanzei requested a review from wiggin77 November 23, 2023 11:47
Copy link

Unit Test Results

93 tests  ±0   93 ✔️ +2   23s ⏱️ ±0s
10 suites ±0     0 💤 ±0 
  1 files   ±0     0  - 2 

Results for commit bb0bd63. ± Comparison against base commit 1d340b9.

Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 23, 2023
@hanzei hanzei merged commit 35caf63 into master Nov 23, 2023
2 checks passed
@hanzei hanzei deleted the flaky-test_map branch November 23, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants