Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refinement of flag parsing (cloud cluster) #774

Merged
merged 4 commits into from
Dec 2, 2022
Merged

refinement of flag parsing (cloud cluster) #774

merged 4 commits into from
Dec 2, 2022

Conversation

mirshahriar
Copy link
Contributor

@mirshahriar mirshahriar commented Nov 30, 2022

Summary

Sample

type clusterUpgradeFlags struct {
	rotatorConfig

	cluster        string
	version        string
}

func (flags *clusterUpgradeFlags) addFlags(command *cobra.Command) {
	flags.rotatorConfig.addFlags(command)

	command.Flags().StringVar(&flags.cluster, "cluster", "", "The id of the cluster to be upgraded.")
	command.Flags().StringVar(&flags.version, "version", "", "The Kubernetes version to target. Use 'latest' or versions such as '1.16.10'.")

	_ = command.MarkFlagRequired("cluster")
}

Ticket Link

Jira Ticket

Release Note

NONE

@mm-cloud-bot mm-cloud-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Nov 30, 2022
@mirshahriar mirshahriar self-assigned this Nov 30, 2022
@mirshahriar mirshahriar added the 2: Dev Review Requires review by a developer label Nov 30, 2022
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! And it'll be easier to maintain. 👍

cmd/cloud/cluster.go Show resolved Hide resolved
cmd/cloud/utils.go Outdated Show resolved Hide resolved
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. No blockers on my end.

cmd/cloud/utils.go Outdated Show resolved Hide resolved
cmd/cloud/main.go Show resolved Hide resolved
@mirshahriar mirshahriar added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Dec 2, 2022
@mirshahriar mirshahriar merged commit f174737 into master Dec 2, 2022
@mirshahriar mirshahriar deleted the MM-48630 branch December 2, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
4 participants