Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move 'server' & 'dry-run' flags to global flagset #778

Merged
merged 4 commits into from
Dec 7, 2022
Merged

move 'server' & 'dry-run' flags to global flagset #778

merged 4 commits into from
Dec 7, 2022

Conversation

mirshahriar
Copy link
Contributor

@mirshahriar mirshahriar commented Dec 5, 2022 •
edited
Loading

Summary

moved server & dry-run flags to global flagset.

Global Flags:
      --dry-run         When set to true, only print the API request without sending it.
      --server string   The provisioning server whose API will be queried. (default "http://localhost:8075")

Missed in this Pull Request.

Also, updated variable names to a common name flags

Ticket Link

Release Note

NONE

@mm-cloud-bot
Copy link

@mirshahriar: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

I understand the commands that are listed here

fmartingr
fmartingr approved these changes Dec 5, 2022
View reviewed changes
Copy link
Contributor

@fmartingr fmartingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@fmartingr fmartingr added the 2: Dev Review Requires review by a developer label Dec 5, 2022
gabrieljackson
gabrieljackson approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@gabrieljackson gabrieljackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrieljackson gabrieljackson added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a developer labels Dec 7, 2022
@mirshahriar mirshahriar merged commit 458f07e into master Dec 7, 2022
@mirshahriar mirshahriar deleted the MM-48630-global-flags branch December 7, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmartingr fmartingr fmartingr approved these changes

@gabrieljackson gabrieljackson gabrieljackson approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request release-note-none Denotes a PR that doesn't merit a release note.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mirshahriar @mm-cloud-bot @fmartingr @gabrieljackson