Add v1.1.0 of mattermost-plugin-apps to the Marketplace #281
Conversation
levb
added
2: Dev Review
| "homepage_url": "https://mattermost.com/marketplace/app-framework", | ||
| "icon_data": "", | ||
| "download_url": "https://plugins-store.test.mattermost.com/release/mattermost-plugin-apps-v1.1.0.tar.gz", | ||
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-apps/releases/tag/v1.0.1", |
There was a problem hiding this comment.
Looks like this was missed in mattermost/mattermost-plugin-apps#345. Maybe something we can automate?
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-apps/releases/tag/v1.0.1", | |
| "release_notes_url": "https://github.com/mattermost/mattermost-plugin-apps/releases/tag/v1.1.0", |
There was a problem hiding this comment.
Right, was overlooked in mattermost/mattermost-plugin-apps#345.
I wonder if we can just autogenerate release_notes_url and leave it empty in plugin.json
Can we leave with the incorrect URL in the plugin itself and not re-cut the release? I can fix this PR so that we have the right URL in the marketplace.
There was a problem hiding this comment.
Can we leave with the incorrect URL in the plugin itself and not re-cut the release? I can fix this PR so that we have the right URL in the marketplace.
@levb Yep works for me
There was a problem hiding this comment.
I wonder if we can just autogenerate
release_notes_urland leave it empty inplugin.json
This would be a "update all plugin repos" change, which has proven to not scale well. Having a common tooling source may be a better way to go about managing the plugin repository tooling. @hanzei What do you think about this? Something like a shared CLI defined in a different repository. Custom make commands for each project would still need to be supported.
|
Should this be merged/closed? |
hanzei
removed
2: Dev Review
|
We don't need this as the plugin is pre packaged |
Release notes at https://github.com/mattermost/mattermost-plugin-apps/releases/tag/v1.1.0